RESOLVED FIXED 208803
REGRESSION(r257977): [GTK] http/tests/media/hls/video-cookie.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=208803
Summary REGRESSION(r257977): [GTK] http/tests/media/hls/video-cookie.html is a flaky ...
Diego Pino
Reported 2020-03-09 03:12:22 PDT
Diff: --- /home/igalia/dpino/workspace/webkit-gtk/layout-test-results/retries/http/tests/media/hls/video-cookie-expected.txt +++ /home/igalia/dpino/workspace/webkit-gtk/layout-test-results/retries/http/tests/media/hls/video-cookie-actual.txt @@ -1,4 +1,4 @@ -EVENT(play) +EVENT(stalled) TEST(false) FAIL END OF TEST
Attachments
Patch (1.47 KB, patch)
2020-03-09 10:22 PDT, Enrique Ocaña
no flags
Patch (1.50 KB, patch)
2020-03-09 10:37 PDT, Enrique Ocaña
no flags
Patch (2.57 KB, patch)
2020-03-10 02:45 PDT, Enrique Ocaña
no flags
Enrique Ocaña
Comment 1 2020-03-09 03:36:31 PDT
Thanks for finding this regression. It's caused by my patch from bug https://bugs.webkit.org/show_bug.cgi?id=205801 (doesn't happen without it, happens with it). I'm having a look at how to fix it.
Enrique Ocaña
Comment 2 2020-03-09 10:22:34 PDT
Enrique Ocaña
Comment 3 2020-03-09 10:29:21 PDT
Before the fix for bug 205801, when a streaming URL stalled a little bit or went slower than expected a duration for the stream was automatically (wrongly) set by WebKit GStreamer. Having a duration it was easier to trigger the end of the download when the actual end of a live stream was reached (and usually much before that). After the fix for bug 205801 the live streams kept their infinite duration. When the server cut the stream, WebKit GStreamer didn't have a way to tell the difference between that situation and a real stall (because of network/server conditions), so it concluded it was a stall. This patch fixed the test to "help" WebKit a little bit avoiding live streams. After all, testing for a cookie has nothing to do with live or non-liveness.
Enrique Ocaña
Comment 4 2020-03-09 10:37:10 PDT
Enrique Ocaña
Comment 5 2020-03-10 02:45:27 PDT
WebKit Commit Bot
Comment 6 2020-03-10 06:56:04 PDT
Comment on attachment 393128 [details] Patch Clearing flags on attachment: 393128 Committed r258205: <https://trac.webkit.org/changeset/258205>
WebKit Commit Bot
Comment 7 2020-03-10 06:56:06 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2020-03-10 06:57:15 PDT
Note You need to log in before you can comment on or make changes to this bug.