Bug 208802 - Add support for overscroll customization parsing
Summary: Add support for overscroll customization parsing
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Scrolling (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: cathiechen
URL:
Keywords:
Depends on:
Blocks: 201556 208813 209134
  Show dependency tree / graph
 
Reported: 2020-03-09 02:18 PDT by cathiechen
Modified: 2023-12-29 00:58 PST (History)
22 users (show)

See Also:

Attachments
Patch (70.69 KB, patch)
2020-03-09 08:07 PDT, cathiechen 		no flags Details | Formatted Diff | Diff
Patch (68.92 KB, patch)
2020-03-09 08:30 PDT, cathiechen 		no flags Details | Formatted Diff | Diff
Patch (68.92 KB, patch)
2020-03-09 23:09 PDT, cathiechen 		no flags Details | Formatted Diff | Diff
Patch (67.92 KB, patch)
2020-03-09 23:46 PDT, cathiechen 		no flags Details | Formatted Diff | Diff
Patch (68.28 KB, patch)
2020-03-09 23:55 PDT, cathiechen 		no flags Details | Formatted Diff | Diff
Patch (67.33 KB, patch)
2020-03-12 09:34 PDT, cathiechen 		no flags Details | Formatted Diff | Diff
Patch (67.40 KB, patch)
2020-03-12 10:16 PDT, cathiechen 		no flags Details | Formatted Diff | Diff
Patch (67.97 KB, patch)
2020-04-09 23:29 PDT, cathiechen 		no flags Details | Formatted Diff | Diff
Show Obsolete (7) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description cathiechen 2020-03-09 02:18:15 PDT 
Add support for overscroll customization parsing, compile flag and preference setting.
Comment 1 cathiechen 2020-03-09 08:07:57 PDT 
Created attachment 393035 [details]
Patch
Comment 2 cathiechen 2020-03-09 08:30:25 PDT 
Created attachment 393036 [details]
Patch
Comment 3 cathiechen 2020-03-09 23:09:33 PDT 
Created attachment 393120 [details]
Patch
Comment 4 cathiechen 2020-03-09 23:46:41 PDT 
Created attachment 393122 [details]
Patch
Comment 5 cathiechen 2020-03-09 23:55:48 PDT 
Created attachment 393124 [details]
Patch
Comment 6 Frédéric Wang (:fredw) 2020-03-10 04:04:59 PDT 
Comment on attachment 393124 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393124&action=review

LGTM, but please wait to have done more for bug 201556 before landing as for now this is not doing anything.

> Source/WebKitLegacy/win/WebPreferenceKeysPrivate.h:217
> +

unneeded whitespace change
Comment 7 Simon Fraser (smfr) 2020-03-11 14:21:45 PDT 
Comment on attachment 393124 [details]
Patch

OVERSCROLL_CUSTOMIZATION is a weird name for this. Maybe OVERSCROLL_EVENTS?
Comment 8 cathiechen 2020-03-12 09:34:16 PDT 
(In reply to Simon Fraser (smfr) from comment #7)
> Comment on attachment 393124 [details]
> Patch
> 
> OVERSCROLL_CUSTOMIZATION is a weird name for this. Maybe OVERSCROLL_EVENTS?

Done, thanks
Comment 9 cathiechen 2020-03-12 09:34:44 PDT 
Created attachment 393384 [details]
Patch
Comment 10 cathiechen 2020-03-12 10:16:26 PDT 
Created attachment 393388 [details]
Patch
Comment 11 cathiechen 2020-04-09 23:29:53 PDT 
Created attachment 396050 [details]
Patch