Bug 208793 – Revise In-App Browser Privacy checks to better reflect the meaning of the flag

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Brent Fulgham]

The 'isInAppBrowserPrivacyEnabled' seems like a feature, but it's really an internal debugging flag.

Revise the use of these calls to make it clearer.

[Radar WebKit Bug Importer]

<rdar://problem/60206256>

[Brent Fulgham]

Created attachment 393000 [details]
Patch

[John Wilander]

Comment on attachment 393000 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393000&action=review

r=me with one comment.

> Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:1219
> +        if (m_isInAppBrowserPrivacyEnabled || NETWORK_SESSION_COCOA_ADDITIONS)

Is there a reason for doing this is two if clauses and not if (isNavigatingToAppBoundDomain == NavigatingToAppBoundDomain::Yes && (m_isInAppBrowserPrivacyEnabled || NETWORK_SESSION_COCOA_ADDITIONS)) ? You do write a single if clause in the second case below.

[Brent Fulgham]

(In reply to John Wilander from comment #3)
> Comment on attachment 393000 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=393000&action=review
> 
> r=me with one comment.
> 
> > Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:1219
> > +        if (m_isInAppBrowserPrivacyEnabled || NETWORK_SESSION_COCOA_ADDITIONS)
> 
> Is there a reason for doing this is two if clauses and not if
> (isNavigatingToAppBoundDomain == NavigatingToAppBoundDomain::Yes &&
> (m_isInAppBrowserPrivacyEnabled || NETWORK_SESSION_COCOA_ADDITIONS)) ? You
> do write a single if clause in the second case below.

I probably should have done both identically.

[Brent Fulgham]

Committed r258124: <https://trac.webkit.org/changeset/258124>

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 393000 [details]:

imported/w3c/web-platform-tests/xhr/open-send-open.htm bug 208794 (author: [e-mail])
The commit-queue is continuing to process your patch.

[Chris Dumez]

Comment on attachment 393000 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393000&action=review

> Source/WebKit/UIProcess/WebPageProxy.cpp:3100
> +    if (isMainFrame && (m_preferences->isInAppBrowserPrivacyEnabled() || WEB_PAGE_PROXY_ADDITIONS_SETISNAVIGATINGTOAPPBOUNDDOMAIN_2)) {

So now this can get enabled even if the pref is disabled? See <rdar://problem/60518694>.