Bug 208791 - CAN_SECURELY_ARCHIVE_FILE_WRAPPER incorrectly excludes watchOS and tvOS
Summary: CAN_SECURELY_ARCHIVE_FILE_WRAPPER incorrectly excludes watchOS and tvOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-08 15:16 PDT by Wenson Hsieh
Modified: 2020-03-08 20:36 PDT (History)
7 users (show)

See Also:

Attachments
Patch (3.90 KB, patch)
2020-03-08 15:30 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Just remove CAN_SECURELY_ARCHIVE_FILE_WRAPPER (3.17 KB, patch)
2020-03-08 17:42 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2020-03-08 15:16:54 PDT 
SSIA
Comment 1 Wenson Hsieh 2020-03-08 15:30:46 PDT Comment hidden (obsolete)
Comment 2 Alexey Proskuryakov 2020-03-08 17:36:37 PDT 
Comment on attachment 392994 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392994&action=review

> Source/WTF/wtf/PlatformUse.h:327
> +#if PLATFORM(IOS_FAMILY) || (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400)

macOS version check is also unnecessary, PLATFORM(COCOA) is enough.
Comment 3 Wenson Hsieh 2020-03-08 17:38:31 PDT 
Comment on attachment 392994 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392994&action=review

>> Source/WTF/wtf/PlatformUse.h:327
>> +#if PLATFORM(IOS_FAMILY) || (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400)
> 
> macOS version check is also unnecessary, PLATFORM(COCOA) is enough.

Ah, I didn’t realize we don’t build for macOS 10.13 updates anymore.

In that case, since this only affects Cocoa code (APIAttachmentCocoa.mm), I think the right thing to do is to simply remove the !CAN_SECURELY_ARCHIVE_FILE_WRAPPER codepath.
Comment 4 Wenson Hsieh 2020-03-08 17:42:12 PDT 
Created attachment 393003 [details]
Just remove CAN_SECURELY_ARCHIVE_FILE_WRAPPER
Comment 5 WebKit Commit Bot 2020-03-08 20:35:23 PDT 
Comment on attachment 393003 [details]
Just remove CAN_SECURELY_ARCHIVE_FILE_WRAPPER

Clearing flags on attachment: 393003

Committed r258128: <https://trac.webkit.org/changeset/258128>
Comment 6 WebKit Commit Bot 2020-03-08 20:35:25 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2020-03-08 20:36:15 PDT 
<rdar://problem/60209784>