Bug 208787 - Build Fix
Summary: Build Fix
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Megan Gardner
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-08 12:18 PDT by Megan Gardner
Modified: 2022-02-10 16:43 PST (History)
2 users (show)

See Also:

Attachments
Patch (3.98 KB, patch)
2020-03-08 12:20 PDT, Megan Gardner 		no flags Details | Formatted Diff | Diff
Patch (3.98 KB, patch)
2020-03-08 12:32 PDT, Megan Gardner 		no flags Details | Formatted Diff | Diff
Patch (3.99 KB, patch)
2020-03-08 12:41 PDT, Megan Gardner 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Megan Gardner 2020-03-08 12:18:41 PDT 
Build Fix
Comment 1 Megan Gardner 2020-03-08 12:20:14 PDT 
Created attachment 392969 [details]
Patch
Comment 2 Tim Horton 2020-03-08 12:21:38 PDT 
Comment on attachment 392969 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392969&action=review

> Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm:719
> +#if USE(UICONTEXTMENU) && HAVE(LINKPREVIEW)

HAVE(LINKPREVIEW) isn't a thing, so you've killed your feature.
Comment 3 Megan Gardner 2020-03-08 12:32:12 PDT 
Created attachment 392973 [details]
Patch
Comment 4 Tim Horton 2020-03-08 12:41:40 PDT 
Comment on attachment 392973 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392973&action=review

> Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm:719
> -#if USE(UICONTEXTMENU)
> +#if USE(UICONTEXTMENU) && HAVE(LINK_PREVIEW)

Pretty sure you want ENABLE(DATA_DETECTION) instead of HAVE(LINK_PREVIEW)
Comment 5 Megan Gardner 2020-03-08 12:41:42 PDT 
Created attachment 392977 [details]
Patch
Comment 6 Megan Gardner 2020-03-08 13:03:32 PDT 
Committed r258110: <https://trac.webkit.org/changeset/258110>
Comment 7 Radar WebKit Bug Importer 2020-03-08 13:04:16 PDT 
<rdar://problem/60203670>