RESOLVED FIXED 208782
Rename ResourceResponseBase::isHTTP to isInHTTPFamily 
https://bugs.webkit.org/show_bug.cgi?id=208782
Summary Rename ResourceResponseBase::isHTTP to isInHTTPFamily
Rob Buis
Reported 2020-03-08 06:32:30 PDT
As the comment says, the method name is misleading and the method is inconsistent with the API of ResourceRequestBase, so remove it.
Attachments
Patch (8.05 KB, patch)
2020-03-08 08:09 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (11.37 KB, patch)
2020-03-09 01:38 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (19.82 KB, patch)
2020-05-30 03:08 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (11.78 KB, patch)
2020-05-30 03:10 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (11.62 KB, patch)
2020-06-01 01:27 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2020-03-08 08:09:49 PDT
Created attachment 392952 [details] Patch
Darin Adler
Comment 2 2020-03-08 22:55:21 PDT
Comment on attachment 392952 [details] Patch Seems OK. Not sure this is an improvement. I would have been tempted to rename it rather than deleting it. Seems logical to check isHTTP() before calling httpStatusCode(), less obvious to check url().protocolIsInHTTPFamily(). WebKitLegacy\win\Plugins\PluginStream.cpp(155,8): error C2039: 'isHTTP': is not a member of 'WebCore::ResourceResponse'
Rob Buis
Comment 3 2020-03-09 01:38:50 PDT
Created attachment 393015 [details] Patch
Rob Buis
Comment 4 2020-03-09 09:14:43 PDT
(In reply to Darin Adler from comment #2) > Comment on attachment 392952 [details] > Patch > > Seems OK. Not sure this is an improvement. I would have been tempted to > rename it rather than deleting it. Seems logical to check isHTTP() before > calling httpStatusCode(), less obvious to check > url().protocolIsInHTTPFamily(). > > WebKitLegacy\win\Plugins\PluginStream.cpp(155,8): error C2039: 'isHTTP': is > not a member of 'WebCore::ResourceResponse' Build error fixed but also willing to rename (Bug title would need to be updated). isHTTPorHTTPS? isInHTTPFamily? Or even protocolIsInHTTPFamily to match URL?
Rob Buis
Comment 5 2020-05-30 03:08:22 PDT
Created attachment 400660 [details] Patch
Rob Buis
Comment 6 2020-05-30 03:10:12 PDT
Created attachment 400661 [details] Patch
EWS
Comment 7 2020-06-01 00:45:04 PDT
ChangeLog entry in Source/WebKitLegacy/win/ChangeLog contains OOPS!.
Rob Buis
Comment 8 2020-06-01 01:27:45 PDT
Created attachment 400725 [details] Patch
EWS
Comment 9 2020-06-01 02:00:01 PDT
Committed r262369: <https://trac.webkit.org/changeset/262369> All reviewed patches have been landed. Closing bug and clearing flags on attachment 400725 [details].
Radar WebKit Bug Importer
Comment 10 2020-06-01 02:01:28 PDT
<rdar://problem/63822588>
Note You need to log in before you can comment on or make changes to this bug.