As the comment says, the method name is misleading and the method is inconsistent with the API of ResourceRequestBase, so remove it.
Created attachment 392952 [details] Patch
Comment on attachment 392952 [details] Patch Seems OK. Not sure this is an improvement. I would have been tempted to rename it rather than deleting it. Seems logical to check isHTTP() before calling httpStatusCode(), less obvious to check url().protocolIsInHTTPFamily(). WebKitLegacy\win\Plugins\PluginStream.cpp(155,8): error C2039: 'isHTTP': is not a member of 'WebCore::ResourceResponse'
Created attachment 393015 [details] Patch
(In reply to Darin Adler from comment #2) > Comment on attachment 392952 [details] > Patch > > Seems OK. Not sure this is an improvement. I would have been tempted to > rename it rather than deleting it. Seems logical to check isHTTP() before > calling httpStatusCode(), less obvious to check > url().protocolIsInHTTPFamily(). > > WebKitLegacy\win\Plugins\PluginStream.cpp(155,8): error C2039: 'isHTTP': is > not a member of 'WebCore::ResourceResponse' Build error fixed but also willing to rename (Bug title would need to be updated). isHTTPorHTTPS? isInHTTPFamily? Or even protocolIsInHTTPFamily to match URL?
Created attachment 400660 [details] Patch
Created attachment 400661 [details] Patch
ChangeLog entry in Source/WebKitLegacy/win/ChangeLog contains OOPS!.
Created attachment 400725 [details] Patch
Committed r262369: <https://trac.webkit.org/changeset/262369> All reviewed patches have been landed. Closing bug and clearing flags on attachment 400725 [details].
<rdar://problem/63822588>