Bug 208782 - Rename ResourceResponseBase::isHTTP to isInHTTPFamily
Summary: Rename ResourceResponseBase::isHTTP to isInHTTPFamily
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-08 06:32 PDT by Rob Buis
Modified: 2020-06-01 02:01 PDT (History)
7 users (show)

See Also:


Attachments
Patch (8.05 KB, patch)
2020-03-08 08:09 PDT, Rob Buis
no flags Details | Formatted Diff | Diff
Patch (11.37 KB, patch)
2020-03-09 01:38 PDT, Rob Buis
no flags Details | Formatted Diff | Diff
Patch (19.82 KB, patch)
2020-05-30 03:08 PDT, Rob Buis
no flags Details | Formatted Diff | Diff
Patch (11.78 KB, patch)
2020-05-30 03:10 PDT, Rob Buis
no flags Details | Formatted Diff | Diff
Patch (11.62 KB, patch)
2020-06-01 01:27 PDT, Rob Buis
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2020-03-08 06:32:30 PDT
As the comment says, the method name is misleading and the method
is inconsistent with the API of ResourceRequestBase, so remove it.
Comment 1 Rob Buis 2020-03-08 08:09:49 PDT
Created attachment 392952 [details]
Patch
Comment 2 Darin Adler 2020-03-08 22:55:21 PDT
Comment on attachment 392952 [details]
Patch

Seems OK. Not sure this is an improvement. I would have been tempted to rename it rather than deleting it. Seems logical to check isHTTP() before calling httpStatusCode(), less obvious to check url().protocolIsInHTTPFamily().

WebKitLegacy\win\Plugins\PluginStream.cpp(155,8): error C2039: 'isHTTP': is not a member of 'WebCore::ResourceResponse'
Comment 3 Rob Buis 2020-03-09 01:38:50 PDT
Created attachment 393015 [details]
Patch
Comment 4 Rob Buis 2020-03-09 09:14:43 PDT
(In reply to Darin Adler from comment #2)
> Comment on attachment 392952 [details]
> Patch
> 
> Seems OK. Not sure this is an improvement. I would have been tempted to
> rename it rather than deleting it. Seems logical to check isHTTP() before
> calling httpStatusCode(), less obvious to check
> url().protocolIsInHTTPFamily().
> 
> WebKitLegacy\win\Plugins\PluginStream.cpp(155,8): error C2039: 'isHTTP': is
> not a member of 'WebCore::ResourceResponse'

Build error fixed but also willing to rename (Bug title would need to be updated).
isHTTPorHTTPS? isInHTTPFamily? Or even protocolIsInHTTPFamily to match URL?
Comment 5 Rob Buis 2020-05-30 03:08:22 PDT
Created attachment 400660 [details]
Patch
Comment 6 Rob Buis 2020-05-30 03:10:12 PDT
Created attachment 400661 [details]
Patch
Comment 7 EWS 2020-06-01 00:45:04 PDT
ChangeLog entry in Source/WebKitLegacy/win/ChangeLog contains OOPS!.
Comment 8 Rob Buis 2020-06-01 01:27:45 PDT
Created attachment 400725 [details]
Patch
Comment 9 EWS 2020-06-01 02:00:01 PDT
Committed r262369: <https://trac.webkit.org/changeset/262369>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 400725 [details].
Comment 10 Radar WebKit Bug Importer 2020-06-01 02:01:28 PDT
<rdar://problem/63822588>