[GPUP] LayoutTest debug assertion crashes: InitDataRegistry::registerInitDataType() called mulitple times with same type

[Jer Noble]

[GPUP] LayoutTest debug assertion crashes: InitDataRegistry::registerInitDataType() called mulitple times with same type

[Jer Noble]

Created attachment 392863 [details]
Patch

[Darin Adler]

Comment on attachment 392863 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392863&action=review

> Source/WebCore/platform/graphics/avfoundation/CDMFairPlayStreaming.cpp:220
> +    static std::once_flag onceFlag;
> +    std::call_once(onceFlag, [] {

For any one code change, seems OK to use std::call_once to avoid calling multiple times, even when the code isn’t safe to use from multiple threads. But since std::call_once is the thread-safe, more-expensive way of doing it, it might be slight overkill. Not sure what our overall project strategy should be for such things.

[WebKit Commit Bot]

Comment on attachment 392863 [details]
Patch

Clearing flags on attachment: 392863

Committed r258099: <https://trac.webkit.org/changeset/258099>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/60195875>