Bug 208763 - Add runtime flag for incremental PDF loading
Summary: Add runtime flag for incremental PDF loading
Status: ASSIGNED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-03-07 08:40 PST by Brady Eidson
Modified: 2020-03-07 14:13 PST (History)
8 users (show)

See Also:

Attachments
Patch (9.03 KB, patch)
2020-03-07 08:57 PST, Brady Eidson 		no flags Details | Formatted Diff | Diff
Patch (9.09 KB, patch)
2020-03-07 09:01 PST, Brady Eidson 		thorton: review+
thorton: commit-queue-
Details | Formatted Diff | Diff
PFL (9.10 KB, patch)
2020-03-07 13:26 PST, Brady Eidson 		no flags Details | Formatted Diff | Diff
PFL (9.08 KB, patch)
2020-03-07 13:30 PST, Brady Eidson 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2020-03-07 08:40:56 PST 
Add runtime flag for incremental PDF loading
Comment 1 Brady Eidson 2020-03-07 08:57:59 PST 
Created attachment 392861 [details]
Patch
Comment 2 Brady Eidson 2020-03-07 09:01:13 PST 
Created attachment 392862 [details]
Patch
Comment 3 Tim Horton 2020-03-07 11:10:02 PST 
Comment on attachment 392862 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392862&action=review

> Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h:330
> +    bool m_incredmentalPDFLoadingEnabled;

INCRED-mental
Comment 4 Brady Eidson 2020-03-07 13:25:38 PST 
(In reply to Tim Horton from comment #3)
> Comment on attachment 392862 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=392862&action=review
> 
> > Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h:330
> > +    bool m_incredmentalPDFLoadingEnabled;
> 
> INCRED-mental

I don't always write patches on the weekends while watching both kids, but when I do, The Incredibles is often on in the background.
Comment 5 Brady Eidson 2020-03-07 13:26:50 PST 
Created attachment 392884 [details]
PFL
Comment 6 Brady Eidson 2020-03-07 13:30:05 PST 
Created attachment 392885 [details]
PFL
Comment 7 WebKit Commit Bot 2020-03-07 14:13:21 PST 
Comment on attachment 392885 [details]
PFL

Clearing flags on attachment: 392885

Committed r258080: <https://trac.webkit.org/changeset/258080>