Bug 208752 – [Media in GPU Process] Implement caption support in video fullscreen and PiP

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Peng Liu]

[Media in GPU Process] Implement caption support in video fullscreen and PiP

[Peng Liu]

<rdar://problem/60178102>

[Peng Liu]

Created attachment 392849 [details]
WIP patch

[Simon Fraser (smfr)]

Comment on attachment 392849 [details]
WIP patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392849&action=review

> Source/WebCore/dom/Document.cpp:2103
> +        // ASSERT_NOT_REACHED();

You cannot remove this. If this hits, you're doing something wrong.

> Source/WebCore/rendering/RenderLayer.cpp:5703
> +            // ASSERT(clipRectsContext.rootLayer == m_clipRectsCache->m_clipRectsRoot[clipRectsType]);
> +            // ASSERT(m_clipRectsCache->m_scrollbarRelevancy[clipRectsType] == clipRectsContext.overlayScrollbarSizeRelevancy);

If you're hitting these you're also doing something wrong.

[Peng Liu]

Created attachment 409415 [details]
Patch

[Peng Liu]

Created attachment 409416 [details]
Fix build failures on WPE and GTK ports

[Peng Liu]

Created attachment 409418 [details]
Fix build failures on WPE and GTK ports v2

[Peng Liu]

Created attachment 409420 [details]
Fix build failures again

[Eric Carlson]

Comment on attachment 409420 [details]
Fix build failures again

View in context: https://bugs.webkit.org/attachment.cgi?id=409420&action=review

> Source/WebKit/WebProcess/GPU/GPUProcessConnection.cpp:154
> +#if PLATFORM(IOS_FAMILY)
> +    if (decoder.messageReceiverName() == Messages::RemoteMediaSessionHelper::messageReceiverName()) {
> +        // FIXME
> +        return true;
> +    }
> +#endif

It might make more sense to add this when we fix RemoteMediaSessionHelper.

[Peng Liu]

Comment on attachment 409420 [details]
Fix build failures again

View in context: https://bugs.webkit.org/attachment.cgi?id=409420&action=review

>> Source/WebKit/WebProcess/GPU/GPUProcessConnection.cpp:154
>> +#endif
> 
> It might make more sense to add this when we fix RemoteMediaSessionHelper.

Agree. But there will be assertion failures if we don't add it. :-(

[EWS]

Committed r267491: <https://trac.webkit.org/changeset/267491>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409420 [details].