Bug 208743 – resultsdbpy: Add tool to manage resultsdbpy container

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Jonathan Bedard]

Add tool to start, stop and restart the resultsdbpy Docker container.

I've found myself doing this sequence of commands enough to get annoyed by it.

[Jonathan Bedard]

Created attachment 392795 [details]
Patch

[Aakash Jain]

Comment on attachment 392795 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392795&action=review

> Tools/ChangeLog:3
> +        resultsdbpy: Add container tool

Bug title should be little more descriptive.

> Tools/resultsdbpy/resultsdbpy/container:59
> +    start_parser = subparsers.add_parser('start', help='Start the container')

container -> 'docker container'?

[Jonathan Bedard]

Created attachment 392811 [details]
Patch

[Aakash Jain]

Comment on attachment 392811 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392811&action=review

> Tools/resultsdbpy/resultsdbpy/container:34
> +    Docker.start()

running check required here?

> Tools/resultsdbpy/resultsdbpy/container:40
> +    if Docker.is_running():

missing not?

[Jonathan Bedard]

Comment on attachment 392811 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392811&action=review

>> Tools/resultsdbpy/resultsdbpy/container:34
>> +    Docker.start()
> 
> running check required here?

The Docker function contains that check already.

[Jonathan Bedard]

Created attachment 392823 [details]
Patch

[Aakash Jain]

Comment on attachment 392823 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392823&action=review

rs=me

> Tools/resultsdbpy/resultsdbpy/container:44
> +    Docker.stop()

Do we need to return 0 here?

> Tools/resultsdbpy/resultsdbpy/container:50
> +    Docker.stop_project(Docker.DEFAULT_PROJECT)

What if stop_project() fails, do we need to handle that? Does the return code of stop_project() indicate that?

[Jonathan Bedard]

Comment on attachment 392823 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392823&action=review

>> Tools/resultsdbpy/resultsdbpy/container:44
>> +    Docker.stop()
> 
> Do we need to return 0 here?

We should, although we don't need to (since 'None' becomes 0)

>> Tools/resultsdbpy/resultsdbpy/container:50
>> +    Docker.stop_project(Docker.DEFAULT_PROJECT)
> 
> What if stop_project() fails, do we need to handle that? Does the return code of stop_project() indicate that?

It's going to raise an exception. The output won't be pretty, but it will be correct.

Generally, these functions aren't expected to fail, so when they do, exceptions are raised.

[Jonathan Bedard]

Created attachment 393032 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 393032 [details]
Patch for landing

Clearing flags on attachment: 393032

Committed r258141: <https://trac.webkit.org/changeset/258141>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/60223645>