Bug 208738 - Consider renaming moveConditionally... MacroAssembler emitters.
Summary: Consider renaming moveConditionally... MacroAssembler emitters.
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-03-06 14:48 PST by Mark Lam
Modified: 2020-03-06 14:49 PST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2020-03-06 14:48:40 PST 
This moveConditionally... functions actually implement csel semantics instead of cmov.  While the "moveConditionally" name can mean select, it is easily confused to mean cmov.  Consider renaming them to variants of "select" or something less ambiguous.