... because DoubleCondition::DoubleNotEqual actually means DoubleNotEqualAndOrdered, but this isn't clear from the name.
Created attachment 392832 [details] proposed patch.
Comment on attachment 392832 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=392832&action=review > Source/JavaScriptCore/ChangeLog:19 > + Renamed the following: > + DoubleEqual ==> DoubleEqualAndOrdered > + DoubleNotEqual ==> DoubleNotEqualAndOrdered > + DoubleGreaterThan ==> DoubleGreaterThanAndOrdered > + DoubleGreaterThanOrEqual ==> DoubleGreaterThanOrEqualAndOrdered > + DoubleLessThan ==> DoubleLessThanAndOrdered > + DoubleLessThanOrEqual ==> DoubleLessThanOrEqualAndOrdered > + > + The comment for these enums in MacroAssemblerARM64.h says: > + // These conditions will only evaluate to true if the comparison is ordered - i.e. neither operand is NaN. > + > + Adding "AndOrdered" to their names makes this property explicit. Isn't this sort of implied?
Comment on attachment 392832 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=392832&action=review r=me. >> Source/JavaScriptCore/ChangeLog:19 >> + Adding "AndOrdered" to their names makes this property explicit. > > Isn't this sort of implied? Can you note that this is interesting because on most CPUs DoubleNotEqual is DoubleNotEqualOrUnordered?
(In reply to Keith Miller from comment #3) > Can you note that this is interesting because on most CPUs DoubleNotEqual is > DoubleNotEqualOrUnordered? Added. Thanks for the review. Landed in r258063: <http://trac.webkit.org/r258063>.
<rdar://problem/60182834>