Bug 208736 - Add "AndOrdered" to the names of ordered DoubleConditions.
Summary: Add "AndOrdered" to the names of ordered DoubleConditions.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-06 14:44 PST by Mark Lam
Modified: 2020-03-06 22:30 PST (History)
6 users (show)

See Also:


Attachments
proposed patch. (60.87 KB, patch)
2020-03-06 18:41 PST, Mark Lam
keith_miller: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2020-03-06 14:44:55 PST
... because DoubleCondition::DoubleNotEqual actually means DoubleNotEqualAndOrdered, but this isn't clear from the name.
Comment 1 Mark Lam 2020-03-06 18:41:08 PST
Created attachment 392832 [details]
proposed patch.
Comment 2 Keith Miller 2020-03-06 20:07:50 PST
Comment on attachment 392832 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=392832&action=review

> Source/JavaScriptCore/ChangeLog:19
> +        Renamed the following:
> +            DoubleEqual ==> DoubleEqualAndOrdered
> +            DoubleNotEqual ==> DoubleNotEqualAndOrdered
> +            DoubleGreaterThan ==> DoubleGreaterThanAndOrdered
> +            DoubleGreaterThanOrEqual ==> DoubleGreaterThanOrEqualAndOrdered
> +            DoubleLessThan ==> DoubleLessThanAndOrdered
> +            DoubleLessThanOrEqual ==> DoubleLessThanOrEqualAndOrdered
> +
> +        The comment for these enums in MacroAssemblerARM64.h says:
> +            // These conditions will only evaluate to true if the comparison is ordered - i.e. neither operand is NaN.
> +
> +        Adding "AndOrdered" to their names makes this property explicit.

Isn't this sort of implied?
Comment 3 Keith Miller 2020-03-06 20:34:54 PST
Comment on attachment 392832 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=392832&action=review

r=me.

>> Source/JavaScriptCore/ChangeLog:19
>> +        Adding "AndOrdered" to their names makes this property explicit.
> 
> Isn't this sort of implied?

Can you note that this is interesting because on most CPUs DoubleNotEqual is DoubleNotEqualOrUnordered?
Comment 4 Mark Lam 2020-03-06 22:30:00 PST
(In reply to Keith Miller from comment #3)
> Can you note that this is interesting because on most CPUs DoubleNotEqual is
> DoubleNotEqualOrUnordered?

Added.

Thanks for the review.  Landed in r258063: <http://trac.webkit.org/r258063>.
Comment 5 Radar WebKit Bug Importer 2020-03-06 22:30:13 PST
<rdar://problem/60182834>