Bug 208727 – [GPUP] Move AVSystemController code into the GPU process

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jer Noble]

[GPUP] Move AVSystemController code into the GPU process

[Jer Noble]

Created attachment 392750 [details]
Patch

[Jer Noble]

Created attachment 392752 [details]
Patch

[Jer Noble]

Created attachment 392755 [details]
Patch

[Eric Carlson]

Comment on attachment 392755 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392755&action=review

> Source/WebCore/platform/audio/ios/MediaSessionHelperIOS.mm:72
> +#if HAVE(MEDIA_PLAYER) && !PLATFORM(WATCHOS)

HAVE_MEDIA_PLAYER is always defined for PLATFORM(COCOA)

> Source/WebCore/platform/audio/ios/MediaSessionHelperIOS.mm:88
> +#if HAVE(MEDIA_PLAYER) && !PLATFORM(WATCHOS)

Ditto.

> Source/WebCore/platform/audio/ios/MediaSessionHelperIOS.mm:183
> +    m_objcObserver = nil;

Nit: this isn't necessary since it is a RetainPtr

> Source/WebCore/platform/audio/ios/MediaSessionHelperIOS.mm:361
> +#if HAVE(MEDIA_PLAYER) && !PLATFORM(WATCHOS)

HAVE_MEDIA_PLAYER is always defined for PLATFORM(COCOA)

> Source/WebCore/platform/audio/ios/MediaSessionHelperIOS.mm:387
> +#if HAVE(MEDIA_PLAYER) && !PLATFORM(WATCHOS)

Ditto

[Jer Noble]

Created attachment 392803 [details]
Patch for landing

[Radar WebKit Bug Importer]

<rdar://problem/60178482>

[Jer Noble]

Won't land until I fix those test failures.

[Jer Noble]

Created attachment 392860 [details]
Patch for landing

[Jer Noble]

Created attachment 392958 [details]
Patch for landing

[Jer Noble]

Created attachment 392961 [details]
Patch for landing

[Jer Noble]

Layout test failure (fast/hidpi/image-srcset-relative-svg-canvas-2x.html) is a failure already in the tree (image diff by 0.01%), and is unrelated. Landing.

[Jer Noble]

Committed r258109: <https://trac.webkit.org/changeset/258109>

[youenn fablet]

We register two applicationWillEnterForeground for get_UIKit_UIApplicationWillEnterForegroundNotification and WebUIApplicationWillEnterForegroundNotification.
Ditto for applicationDidBecomeActive, applicationWillResignActive and applicationDidEnterBackground.

Given we post a WebUIApplicationWillEnterForegroundNotification notification from WebProcess/WebPage, shouldn't we listen to this notification from WebProcess only?

Maybe we do not need WebUIApplicationWillEnterForegroundNotification anymore and can rely on get_UIKit_UIApplicationWillEnterForegroundNotification only? Ditto for others?

Also, we are listening for UIKit_UIApplicationWillEnterForegroundNotification in both UIProcess and GPUProcess. Do we need both? If we need both, should we try to have a single code path (GPUProcess -> UIProcess -> WebProcess for instance)?