RESOLVED FIXED 208719
Web Inspector: Fix missing icons for WI.ThreadTreeElement and selected Heap Snapshots 
https://bugs.webkit.org/show_bug.cgi?id=208719
Summary Web Inspector: Fix missing icons for WI.ThreadTreeElement and selected Heap S...
Jon Davis
Reported 2020-03-06 09:34:55 PST
Add back the missing Thread icon used in WIThreadTreeElement.
Attachments
Patch (4.60 KB, patch)
2020-03-06 09:50 PST, Jon Davis 		no flags
DetailsFormatted DiffDiff
Patch (33.36 KB, patch)
2020-03-06 14:58 PST, Jon Davis 		no flags
DetailsFormatted DiffDiff
Selected Heap Snapshot in dark mode (248.79 KB, image/png)
2020-03-06 14:59 PST, Jon Davis 		no flags
Details
Selected Heap Snapshot in light mode (231.71 KB, image/png)
2020-03-06 14:59 PST, Jon Davis 		no flags
Details
Thread and TypeObject icons in dark mode (183.98 KB, image/png)
2020-03-06 15:00 PST, Jon Davis 		no flags
Details
Thread and TypeObject icons in light mode (176.96 KB, image/png)
2020-03-06 15:01 PST, Jon Davis 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jon Davis
Comment 1 2020-03-06 09:50:39 PST
Created attachment 392733 [details] Patch
Devin Rousso
Comment 2 2020-03-06 10:22:45 PST
Comment on attachment 392733 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392733&action=review r=me > Source/WebInspectorUI/UserInterface/Images/InstrumentIcons.svg:171 > + <g id="ThreadInstrument-light" class="light blue"><use href="#circle"/><use href="#threads"/></g> > + <g id="ThreadInstrument-dark" class="dark blue"><use href="#circle"/><use href="#threads"/></g> I wouldn't really consider this an "instrument". That's a concept specific to timelines. It's not the worst thing for it to use this as well, but it would be nice to have it as it's own icon as it's really a unique concept.
Jon Davis
Comment 3 2020-03-06 10:57:37 PST
Maybe incorporate it into the object type icons with the rounded rect style instead?
Jon Davis
Comment 4 2020-03-06 14:58:54 PST
Created attachment 392776 [details] Patch
Jon Davis
Comment 5 2020-03-06 14:59:33 PST
Created attachment 392777 [details] Selected Heap Snapshot in dark mode
Jon Davis
Comment 6 2020-03-06 14:59:49 PST
Created attachment 392778 [details] Selected Heap Snapshot in light mode
Jon Davis
Comment 7 2020-03-06 15:00:59 PST
Created attachment 392779 [details] Thread and TypeObject icons in dark mode
Jon Davis
Comment 8 2020-03-06 15:01:34 PST
Created attachment 392780 [details] Thread and TypeObject icons in light mode
Devin Rousso
Comment 9 2020-03-06 16:34:51 PST
Comment on attachment 392776 [details] Patch r=me, nice!
WebKit Commit Bot
Comment 10 2020-03-06 17:18:49 PST
Comment on attachment 392776 [details] Patch Clearing flags on attachment: 392776 Committed r258039: <https://trac.webkit.org/changeset/258039>
WebKit Commit Bot
Comment 11 2020-03-06 17:18:50 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 12 2020-03-06 17:19:18 PST
<rdar://problem/60177324>
Note You need to log in before you can comment on or make changes to this bug.