Bug 208716 - [ews] commit queue is not skipping layout tests for rollout patches
Summary: [ews] commit queue is not skipping layout tests for rollout patches
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-06 08:26 PST by Aakash Jain
Modified: 2020-03-07 16:15 PST (History)
4 users (show)

See Also:

Attachments
Patch (2.83 KB, patch)
2020-03-06 08:28 PST, Aakash Jain 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2020-03-06 08:26:19 PST 
[ews] commit queue is not skipping layout tests for rollout patches after r257927. e.g.: https://ews-build.webkit-uat.org/#/builders/26/builds/1165

The logic to skip tests was added only for WK1 tests, and in r257927 we should from wk1 to wk2 for commit-queue. We should skip wk2 tests as well in commit-queue in case of rollout patch.
Comment 1 Aakash Jain 2020-03-06 08:28:23 PST 
Created attachment 392725 [details]
Patch
Comment 2 Aakash Jain 2020-03-07 16:14:53 PST 
Committed r258084: <https://trac.webkit.org/changeset/258084>
Comment 3 Radar WebKit Bug Importer 2020-03-07 16:15:14 PST 
<rdar://problem/60193629>