Bug 208707 – Add support for NowPlaying commands in GPUProcess

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[youenn fablet]

Add support for NowPlaying commands in GPUProcess

[youenn fablet]

Created attachment 392709 [details]
Patch

[youenn fablet]

Created attachment 392712 [details]
Patch

[Eric Carlson]

Comment on attachment 392712 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392712&action=review

> Source/WebKit/ChangeLog:9
> +        Each GPUConnectionToWebProcess is nwo a NowPlayingManager client.

s/nwo/now/

> Source/WebCore/platform/NowPlayingManager.cpp:59
> +    if (m_client.get() != &client)
> +        return;

Should we ASSERT this?

> Source/WebCore/platform/NowPlayingManager.h:53
> +    void clearNowPlayingInfo(Client&);
> +    void setNowPlayingInfo(Client&, NowPlayingInfo&&);

Nit: It seems like this is really about setting/clearing the client, so I wonder if "NowPlayingClient" would be better than "NowPlayingInfo"?

[youenn fablet]

> > Source/WebCore/platform/NowPlayingManager.cpp:59
> > +    if (m_client.get() != &client)
> > +        return;
> 
> Should we ASSERT this?

A clear from one process might be racy with a setNowPlayingInfo from another.

> > Source/WebCore/platform/NowPlayingManager.h:53
> > +    void clearNowPlayingInfo(Client&);
> > +    void setNowPlayingInfo(Client&, NowPlayingInfo&&);
> 
> Nit: It seems like this is really about setting/clearing the client, so I
> wonder if "NowPlayingClient" would be better than "NowPlayingInfo"?

OK.

[youenn fablet]

Created attachment 392731 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 392731 [details]
Patch for landing

Rejecting attachment 392731 [details] from commit-queue.

New failing tests:
editing/spelling/spellcheck-async-remove-frame.html
Full output: https://webkit-queues.webkit.org/results/13334823

[WebKit Commit Bot]

Created attachment 392744 [details]
Archive of layout-test-results from webkit-cq-01 for mac-mojave

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-01  Port: mac-mojave  Platform: Mac OS X 10.14.6

[WebKit Commit Bot]

Comment on attachment 392731 [details]
Patch for landing

Clearing flags on attachment: 392731

Committed r258015: <https://trac.webkit.org/changeset/258015>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/60165283>