Bug 208705 - JSDOMIterator classes should be in IsoSubspace
Summary: JSDOMIterator classes should be in IsoSubspace
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-06 03:52 PST by Yusuke Suzuki
Modified: 2020-03-06 15:04 PST (History)
12 users (show)

See Also:


Attachments
Patch (111.37 KB, patch)
2020-03-06 05:02 PST, Yusuke Suzuki
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2020-03-06 03:52:01 PST
IIUC, this is the last thing we should put it into IsoSubspace in WebCore side.
Comment 1 Yusuke Suzuki 2020-03-06 03:53:47 PST
We should collect iterator classes in preprocess-idls.pl. And putting all of them into DOMIsoSubspaces class. And instead of using typedef-ed JSDOMIterator directly, we should create a class which is inheriting JSDOMIteratorImpl<Class>, and offering subspaceFor implementation.

And another thing we should do is putting `void subspaceFor` implementation for JSDOMObject to ensure that any derived classes of JSDOMObject should not get allocated from non IsoSubspace.
Comment 2 Yusuke Suzuki 2020-03-06 05:02:14 PST
Created attachment 392707 [details]
Patch
Comment 3 Yusuke Suzuki 2020-03-06 15:03:22 PST
Committed r258032: <https://trac.webkit.org/changeset/258032>
Comment 4 Radar WebKit Bug Importer 2020-03-06 15:04:16 PST
<rdar://problem/60172271>