Bug 208699 – [GPUP] Convert CDMFactory away from platformStrategies() and use WebProcess settings instead

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jer Noble]

[GPUP] Convert CDMFactory away from platformStrategies() and use WebProcess settings instead

[Jer Noble]

Created attachment 392682 [details]
Patch

[youenn fablet]

Comment on attachment 392682 [details]
Patch

r=me as long as bots are green.

View in context: https://bugs.webkit.org/attachment.cgi?id=392682&action=review

> Source/WebKit/WebProcess/WebProcess.cpp:2011
> +    cdmFactories.clear();

This seems a bit odd to get the vector, clear it and then refill it and passing it as a mutable parameter.
I guess this might help for extensibility.

Could we just have something like :
static inline Vector<CDMFactory*> computeFactories()
{
   if (useGPUProcessForMedia)
     return ensureGPUProcessConnection().cdmFactory().computeFactories();
  return CDMFactory::computePlatformFactories();
}
...

    CDMFactory::registerFactories(computeFactories())

> Source/WebKit/WebProcess/WebProcess.cpp:2013
> +    if (useGPUProcessForMedia)

Probably missing a ENABLE(GPU_PROCESS)

[Aakash Jain]

Please check https://ews-build.webkit.org/#/builders/8/builds/17625/steps/8/logs/stdio

[Jer Noble]

(In reply to Aakash Jain from comment #3)
> Please check
> https://ews-build.webkit.org/#/builders/8/builds/17625/steps/8/logs/stdio

Yes, that's what Youenn's comment about a missing ENABLE(GPU_PROCESS) guard addresses.

[Jer Noble]

(In reply to youenn fablet from comment #2)
> Comment on attachment 392682 [details]
> Patch
> 
> r=me as long as bots are green.
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=392682&action=review
> 
> > Source/WebKit/WebProcess/WebProcess.cpp:2011
> > +    cdmFactories.clear();
> 
> This seems a bit odd to get the vector, clear it and then refill it and
> passing it as a mutable parameter.
> I guess this might help for extensibility.

I took a pass at this, but it requires a lot of re-architecture of port-specific code; it should be left as a clean-up task.

[Jer Noble]

Created attachment 392782 [details]
Patch for landing

[WebKit Commit Bot]

ChangeLog entry in Source/WebKitLegacy/mac/ChangeLog contains OOPS!.

[WebKit Commit Bot]

Comment on attachment 392782 [details]
Patch for landing

Rejecting attachment 392782 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 392782, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebKitLegacy/mac/ChangeLog contains OOPS!.

Full output: https://webkit-queues.webkit.org/results/13335013

[Jer Noble]

Created attachment 392805 [details]
Patch for landing

[Jer Noble]

Created attachment 392806 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 392806 [details]
Patch for landing

Clearing flags on attachment: 392806

Committed r258040: <https://trac.webkit.org/changeset/258040>

[Radar WebKit Bug Importer]

<rdar://problem/60178373>