Some PDFPlugin cleanup in prep for incremental loading The frame is never cleared, so make it a reference. Use a new "number of streamed bytes" variable instead of grabbing m_data's length, as m_data will soon become a "sparse" data buffer
Created attachment 392681 [details] Patch
Created attachment 392719 [details] Patch
Comment on attachment 392719 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392719&action=review > Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h:275 > + WebFrame& m_frame; Should we use a WeakPtr instead? > Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:1347 > + if (FrameView* frameView = m_frame.coreFrame()->view()) auto? > Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:1854 > + Frame* frame = m_frame.coreFrame(); auto?
(In reply to Alex Christensen from comment #3) > Comment on attachment 392719 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=392719&action=review > > > Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h:275 > > + WebFrame& m_frame; > > Should we use a WeakPtr instead? As this is no behavior change and we have no reason to believe it's currently a problem, not right now. > > > Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:1347 > > + if (FrameView* frameView = m_frame.coreFrame()->view()) > > auto? > > > Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:1854 > > + Frame* frame = m_frame.coreFrame(); > > auto? Sure.
Created attachment 392786 [details] PFL
Comment on attachment 392786 [details] PFL Clearing flags on attachment: 392786 Committed r258043: <https://trac.webkit.org/changeset/258043>
All reviewed patches have been landed. Closing bug.
<rdar://problem/60178033>