Bug 208693 – [webkitpy] Fix executive on Windows to run wpt server correctly

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Basuke Suzuki]

Caused by typo.

[Basuke Suzuki]

Created attachment 392796 [details]
PATCH

[Fujii Hironori]

Comment on attachment 392796 [details]
PATCH

View in context: https://bugs.webkit.org/attachment.cgi?id=392796&action=review

> Source/WebCore/loader/cache/CachedImage.cpp:569
> +    }

Whats this?

[Basuke Suzuki]

Created attachment 392798 [details]
PATCH

[Basuke Suzuki]

Sorry, I submitted a wrong file X( New one is good to go.

[Jonathan Bedard]

Comment on attachment 392798 [details]
PATCH

View in context: https://bugs.webkit.org/attachment.cgi?id=392798&action=review

> Tools/Scripts/webkitpy/common/system/executive.py:324
> +    def _windows_killCommand(self):

If this is an instance function, we shouldn't need the 'self._is_native_win' in kill_all.

Otherwise it should be a staticmethod or a class variable (Like what we did with PIPE and STDOUT)

[Basuke Suzuki]

Created attachment 392812 [details]
PATCH

[Jonathan Bedard]

Comment on attachment 392812 [details]
PATCH

View in context: https://bugs.webkit.org/attachment.cgi?id=392812&action=review

> Tools/Scripts/webkitpy/common/system/executive.py:326
> +            return os.path.join("C:", os.sep, "WINDOWS", "system32", "taskkill.exe")

Do we actually need os.sep here? I would expect os.path.join(...) to do that for you.

[Basuke Suzuki]

Comment on attachment 392812 [details]
PATCH

View in context: https://bugs.webkit.org/attachment.cgi?id=392812&action=review

>> Tools/Scripts/webkitpy/common/system/executive.py:326
>> +            return os.path.join("C:", os.sep, "WINDOWS", "system32", "taskkill.exe")
> 
> Do we actually need os.sep here? I would expect os.path.join(...) to do that for you.

Well that part is copied from existing code, which is working. So I left untouched that.

[WebKit Commit Bot]

Comment on attachment 392812 [details]
PATCH

Clearing flags on attachment: 392812

Committed r258045: <https://trac.webkit.org/changeset/258045>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/60178285>