Caused by typo.
Created attachment 392796 [details] PATCH
Comment on attachment 392796 [details] PATCH View in context: https://bugs.webkit.org/attachment.cgi?id=392796&action=review > Source/WebCore/loader/cache/CachedImage.cpp:569 > + } Whats this?
Created attachment 392798 [details] PATCH
Sorry, I submitted a wrong file X( New one is good to go.
Comment on attachment 392798 [details] PATCH View in context: https://bugs.webkit.org/attachment.cgi?id=392798&action=review > Tools/Scripts/webkitpy/common/system/executive.py:324 > + def _windows_killCommand(self): If this is an instance function, we shouldn't need the 'self._is_native_win' in kill_all. Otherwise it should be a staticmethod or a class variable (Like what we did with PIPE and STDOUT)
Created attachment 392812 [details] PATCH
Comment on attachment 392812 [details] PATCH View in context: https://bugs.webkit.org/attachment.cgi?id=392812&action=review > Tools/Scripts/webkitpy/common/system/executive.py:326 > + return os.path.join("C:", os.sep, "WINDOWS", "system32", "taskkill.exe") Do we actually need os.sep here? I would expect os.path.join(...) to do that for you.
Comment on attachment 392812 [details] PATCH View in context: https://bugs.webkit.org/attachment.cgi?id=392812&action=review >> Tools/Scripts/webkitpy/common/system/executive.py:326 >> + return os.path.join("C:", os.sep, "WINDOWS", "system32", "taskkill.exe") > > Do we actually need os.sep here? I would expect os.path.join(...) to do that for you. Well that part is copied from existing code, which is working. So I left untouched that.
Comment on attachment 392812 [details] PATCH Clearing flags on attachment: 392812 Committed r258045: <https://trac.webkit.org/changeset/258045>
All reviewed patches have been landed. Closing bug.
<rdar://problem/60178285>