RESOLVED FIXED 208692
TextManipulationController should preserve images 
https://bugs.webkit.org/show_bug.cgi?id=208692
Summary TextManipulationController should preserve images
Ryosuke Niwa
Reported 2020-03-05 20:56:36 PST
TextManipulationController shouldn't rip out all the images.
Attachments
WIP (16.86 KB, patch)
2020-03-05 20:57 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Patch (22.92 KB, patch)
2020-03-06 02:15 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Added more change log descriptions (23.41 KB, patch)
2020-03-06 02:22 PST, Ryosuke Niwa 		wenson_hsieh: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2020-03-05 20:57:12 PST
Created attachment 392669 [details] WIP
Ryosuke Niwa
Comment 2 2020-03-06 02:15:48 PST
Created attachment 392694 [details] Patch
Ryosuke Niwa
Comment 3 2020-03-06 02:22:14 PST
Created attachment 392695 [details] Added more change log descriptions
Ryosuke Niwa
Comment 4 2020-03-06 02:22:22 PST
<rdar://problem/58810183>
Wenson Hsieh
Comment 5 2020-03-06 08:41:47 PST
Comment on attachment 392695 [details] Added more change log descriptions View in context: https://bugs.webkit.org/attachment.cgi?id=392695&action=review > Source/WebCore/ChangeLog:15 > + including ones that do not generate text in Textiterator. This also allows more code sharing between Nit - Textiterator => TextIterator > Source/WebCore/ChangeLog:18 > + For now, we special case nodes with RenderReplace like img element and the root SVG element. Nit - RenderReplace => RenderReplaced
Ryosuke Niwa
Comment 6 2020-03-06 15:55:40 PST
(In reply to Wenson Hsieh from comment #5) > Comment on attachment 392695 [details] > Added more change log descriptions > > View in context: > https://bugs.webkit.org/attachment.cgi?id=392695&action=review > > > Source/WebCore/ChangeLog:15 > > + including ones that do not generate text in Textiterator. This also allows more code sharing between > > Nit - Textiterator => TextIterator > > > Source/WebCore/ChangeLog:18 > > + For now, we special case nodes with RenderReplace like img element and the root SVG element. > > Nit - RenderReplace => RenderReplaced Fixed these typos.
Ryosuke Niwa
Comment 7 2020-03-06 17:14:25 PST
Committed r258037: <https://trac.webkit.org/changeset/258037>
Note You need to log in before you can comment on or make changes to this bug.