Bug 208692 - TextManipulationController should preserve images
Summary: TextManipulationController should preserve images
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-05 20:56 PST by Ryosuke Niwa
Modified: 2020-03-06 17:14 PST (History)
5 users (show)

See Also:


Attachments
WIP (16.86 KB, patch)
2020-03-05 20:57 PST, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Patch (22.92 KB, patch)
2020-03-06 02:15 PST, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Added more change log descriptions (23.41 KB, patch)
2020-03-06 02:22 PST, Ryosuke Niwa
wenson_hsieh: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2020-03-05 20:56:36 PST
TextManipulationController shouldn't rip out all the images.
Comment 1 Ryosuke Niwa 2020-03-05 20:57:12 PST
Created attachment 392669 [details]
WIP
Comment 2 Ryosuke Niwa 2020-03-06 02:15:48 PST
Created attachment 392694 [details]
Patch
Comment 3 Ryosuke Niwa 2020-03-06 02:22:14 PST
Created attachment 392695 [details]
Added more change log descriptions
Comment 4 Ryosuke Niwa 2020-03-06 02:22:22 PST
<rdar://problem/58810183>
Comment 5 Wenson Hsieh 2020-03-06 08:41:47 PST
Comment on attachment 392695 [details]
Added more change log descriptions

View in context: https://bugs.webkit.org/attachment.cgi?id=392695&action=review

> Source/WebCore/ChangeLog:15
> +        including ones that do not generate text in Textiterator. This also allows more code sharing between

Nit - Textiterator => TextIterator

> Source/WebCore/ChangeLog:18
> +        For now, we special case nodes with RenderReplace like img element and the root SVG element.

Nit - RenderReplace => RenderReplaced
Comment 6 Ryosuke Niwa 2020-03-06 15:55:40 PST
(In reply to Wenson Hsieh from comment #5)
> Comment on attachment 392695 [details]
> Added more change log descriptions
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=392695&action=review
> 
> > Source/WebCore/ChangeLog:15
> > +        including ones that do not generate text in Textiterator. This also allows more code sharing between
> 
> Nit - Textiterator => TextIterator
> 
> > Source/WebCore/ChangeLog:18
> > +        For now, we special case nodes with RenderReplace like img element and the root SVG element.
> 
> Nit - RenderReplace => RenderReplaced

Fixed these typos.
Comment 7 Ryosuke Niwa 2020-03-06 17:14:25 PST
Committed r258037: <https://trac.webkit.org/changeset/258037>