Bug 208691 – Implementation of AccessibilitySupport AXSIsolatedTreeMode.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Andres Gonzalez]

Implementation of HIServices AXSIsolatedTreeMode.

[Andres Gonzalez]

Created attachment 392668 [details]
Patch

[Andres Gonzalez]

Created attachment 392714 [details]
Patch

[Andres Gonzalez]

Created attachment 392734 [details]
Patch

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 392734 [details]:

media/track/track-in-band-metadata-display-order.html bug 206226 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 392734 [details]
Patch

Clearing flags on attachment: 392734

Committed r258047: <https://trac.webkit.org/changeset/258047>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/60178602>

[Andres Gonzalez]

This change was rolled out due to incompatibility with SDK.

[Andres Gonzalez]

Created attachment 392965 [details]
Patch

[Andres Gonzalez]

Fixes incompatibility with SDK by softlinking with AccessibilitySupport.

[Andres Gonzalez]

Created attachment 392975 [details]
Patch

[Andres Gonzalez]

Created attachment 392980 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 392980 [details]
Patch

Clearing flags on attachment: 392980

Committed r258115: <https://trac.webkit.org/changeset/258115>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Chris Dumez]

(In reply to WebKit Commit Bot from comment #14)
> All reviewed patches have been landed.  Closing bug.

I have been having trouble building since this change:
Source/WebCore/PAL/pal/spi/cocoa/AccessibilitySupportSoftLink.h:36:85: error: unknown type name 'AXSIsolatedTreeMode'

[Dean Jackson]

(In reply to Chris Dumez from comment #15)
> (In reply to WebKit Commit Bot from comment #14)
> > All reviewed patches have been landed.  Closing bug.
> 
> I have been having trouble building since this change:
> Source/WebCore/PAL/pal/spi/cocoa/AccessibilitySupportSoftLink.h:36:85:
> error: unknown type name 'AXSIsolatedTreeMode'

Same here. I don't see AXSIsolatedTreeMode defined anywhere in current or future versions of macOS.

[chris fleizach]

(In reply to Dean Jackson from comment #16)
> (In reply to Chris Dumez from comment #15)
> > (In reply to WebKit Commit Bot from comment #14)
> > > All reviewed patches have been landed.  Closing bug.
> > 
> > I have been having trouble building since this change:
> > Source/WebCore/PAL/pal/spi/cocoa/AccessibilitySupportSoftLink.h:36:85:
> > error: unknown type name 'AXSIsolatedTreeMode'
> 
> Same here. I don't see AXSIsolatedTreeMode defined anywhere in current or
> future versions of macOS.

You would need a recent version of SDK.

[Dean Jackson]

In the future if a change requires an SDK that is newer than a couple of days old, could you email our internal list to let people know? (or, even better, stage it so that people don't need to upgrade).

[Saagar Jha]

Hi, sorry to resurrect a months-old bug, but I'm seeing a build failure suspiciously similar to the one described here when using the public 10.16 SDK. If AXSIsolatedTreeMode is SPI (it looks like it is?) would you mind adding a stub or polyfill of some sort so that I can build WebKit without it?