Bug 208689 – [WPE] MiniBrowser: Close child WebViews when exiting

• Status: RESOLVED
• Resolution: FIXED
• Component: WPE WebKit

[Lauro Moura]

During the discussion in bug207529, it was noted that WPE's MiniBrowser only cleans up the main webview when exiting, while ideally it should also clean up any child view created.

[Lauro Moura]

Created attachment 393008 [details]
Patch

[Zan Dobersek]

Comment on attachment 393008 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393008&action=review

> Tools/MiniBrowser/wpe/main.cpp:308
> +    g_signal_connect(webView, "close", G_CALLBACK(+[](WebKitWebView *view, gpointer) {

That + is redundant.

[Carlos Garcia Campos]

Comment on attachment 393008 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393008&action=review

>> Tools/MiniBrowser/wpe/main.cpp:308
>> +    g_signal_connect(webView, "close", G_CALLBACK(+[](WebKitWebView *view, gpointer) {
> 
> That + is redundant.

I think you can use G_CALLBACK(g_object_unref) directly. Maybe it's easier to add the main web view to the hash table and you don't need to handle it differently. You could use a weak ref to remove the web views from the hash table when they are destroyed, too.

[Lauro Moura]

Created attachment 393105 [details]
Patch

[Lauro Moura]

Created attachment 393119 [details]
Patch

[Carlos Garcia Campos]

Comment on attachment 393119 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393119&action=review

> Tools/MiniBrowser/wpe/main.cpp:154
> +    g_hash_table_remove(openViews, (gpointer*)webView);

This is cpp file, use C++ cast.

> Tools/MiniBrowser/wpe/main.cpp:174
> +    g_hash_table_add(openViews, (gpointer*)newWebView);

Ditto.

> Tools/MiniBrowser/wpe/main.cpp:303
> +    openViews = g_hash_table_new_full(NULL, NULL, g_object_unref, NULL);

And nullptr instead of NULL.

[Lauro Moura]

Created attachment 393153 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 393153 [details]
Patch

Clearing flags on attachment: 393153

Committed r258211: <https://trac.webkit.org/changeset/258211>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.