During the discussion in bug207529, it was noted that WPE's MiniBrowser only cleans up the main webview when exiting, while ideally it should also clean up any child view created.
Created attachment 393008 [details] Patch
Comment on attachment 393008 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393008&action=review > Tools/MiniBrowser/wpe/main.cpp:308 > + g_signal_connect(webView, "close", G_CALLBACK(+[](WebKitWebView *view, gpointer) { That + is redundant.
Comment on attachment 393008 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393008&action=review >> Tools/MiniBrowser/wpe/main.cpp:308 >> + g_signal_connect(webView, "close", G_CALLBACK(+[](WebKitWebView *view, gpointer) { > > That + is redundant. I think you can use G_CALLBACK(g_object_unref) directly. Maybe it's easier to add the main web view to the hash table and you don't need to handle it differently. You could use a weak ref to remove the web views from the hash table when they are destroyed, too.
Created attachment 393105 [details] Patch
Created attachment 393119 [details] Patch
Comment on attachment 393119 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393119&action=review > Tools/MiniBrowser/wpe/main.cpp:154 > + g_hash_table_remove(openViews, (gpointer*)webView); This is cpp file, use C++ cast. > Tools/MiniBrowser/wpe/main.cpp:174 > + g_hash_table_add(openViews, (gpointer*)newWebView); Ditto. > Tools/MiniBrowser/wpe/main.cpp:303 > + openViews = g_hash_table_new_full(NULL, NULL, g_object_unref, NULL); And nullptr instead of NULL.
Created attachment 393153 [details] Patch
Comment on attachment 393153 [details] Patch Clearing flags on attachment: 393153 Committed r258211: <https://trac.webkit.org/changeset/258211>
All reviewed patches have been landed. Closing bug.