Bug 208669 – Pre-fetch first page in new PDF loading model

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Brady Eidson]

Pre-fetch first page in new PDF loading model

[Brady Eidson]

Created attachment 392638 [details]
Patch

[Alex Christensen]

Comment on attachment 392638 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392638&action=review

> Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:98
> +-(void) preloadDataOfPagesInRange:(NSRange)range onQueue:(dispatch_queue_t)queue completion:(void (^)(NSIndexSet* loadedPageIndexes))completionBlock;

Space in wrong place.
Same with previous line.

> Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:711
> +    auto firstPageQueue = WorkQueue::create("PDF first page work queue");

We should reuse this.

[Brady Eidson]

(In reply to Alex Christensen from comment #2)
> Comment on attachment 392638 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=392638&action=review
> 
> > Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:98
> > +-(void) preloadDataOfPagesInRange:(NSRange)range onQueue:(dispatch_queue_t)queue completion:(void (^)(NSIndexSet* loadedPageIndexes))completionBlock;
> 
> Space in wrong place.
> Same with previous line.
> 
> > Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:711
> > +    auto firstPageQueue = WorkQueue::create("PDF first page work queue");
> 
> We should reuse this.

There's only ever one per PDFPlugin, and there's (generally) only ever one PDFPlugin per WebContent process.

So I agree in principal, but in practice it's a non-issue.

[Brady Eidson]

Created attachment 392643 [details]
PFL

[Radar WebKit Bug Importer]

<rdar://problem/60112775>

[Radar WebKit Bug Importer]

<rdar://problem/60112772>

[WebKit Commit Bot]

Comment on attachment 392643 [details]
PFL

Clearing flags on attachment: 392643

Committed r257964: <https://trac.webkit.org/changeset/257964>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.