Bug 208666 - Add web page additions to WebPageProxy
Summary: Add web page additions to WebPageProxy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kate Cheney
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-05 14:26 PST by Kate Cheney
Modified: 2020-03-05 16:21 PST (History)
4 users (show)

See Also:


Attachments
Patch (2.03 KB, patch)
2020-03-05 14:51 PST, Kate Cheney
no flags Details | Formatted Diff | Diff
Patch (2.12 KB, patch)
2020-03-05 15:15 PST, Kate Cheney
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kate Cheney 2020-03-05 14:26:09 PST
Add web page additions to WebPageProxy
Comment 1 Radar WebKit Bug Importer 2020-03-05 14:26:37 PST
<rdar://problem/60100413>
Comment 2 Kate Cheney 2020-03-05 14:51:21 PST
Created attachment 392628 [details]
Patch
Comment 3 Chris Dumez 2020-03-05 14:53:28 PST
Comment on attachment 392628 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392628&action=review

> Source/WebKit/UIProcess/WebPageProxy.cpp:282
> +#define WEB_PAGE_PROXY_ADDITIONS_1

Can we find better names? Maybe WEB_PAGE_PROXY_ADDITIONS_ISAPPBOUNDDOMAIN & WEB_PAGE_PROXY_ADDITIONS_SETISNAVIGATINGTOAPPBOUNDDOMAIN ?
Comment 4 Kate Cheney 2020-03-05 15:15:00 PST
Created attachment 392633 [details]
Patch
Comment 5 Brent Fulgham 2020-03-05 15:18:31 PST
Comment on attachment 392633 [details]
Patch

r=me
Comment 6 WebKit Commit Bot 2020-03-05 16:21:22 PST
Comment on attachment 392633 [details]
Patch

Clearing flags on attachment: 392633

Committed r257957: <https://trac.webkit.org/changeset/257957>
Comment 7 WebKit Commit Bot 2020-03-05 16:21:23 PST
All reviewed patches have been landed.  Closing bug.