Bug 208663 - [First paint] Fixed sized SVG content should taken into account when computing VNE status
Summary: [First paint] Fixed sized SVG content should taken into account when computin...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-05 13:11 PST by zalan
Modified: 2020-03-05 15:44 PST (History)
10 users (show)

See Also:

Attachments
Patch (2.29 KB, patch)
2020-03-05 13:16 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (2.42 KB, patch)
2020-03-05 14:57 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (2.42 KB, patch)
2020-03-05 14:58 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2020-03-05 13:11:06 PST 
ssia
Comment 1 Radar WebKit Bug Importer 2020-03-05 13:11:30 PST 
<rdar://problem/60096896>
Comment 2 zalan 2020-03-05 13:16:33 PST 
Created attachment 392613 [details]
Patch
Comment 3 Simon Fraser (smfr) 2020-03-05 13:48:34 PST 
Comment on attachment 392613 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392613&action=review

> Source/WebCore/ChangeLog:9
> +        Let's add fixed sized SVG to the list if content we track as VNE pixel count.

if -> of

> Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:944
> +        // SVG content tends to have a fixed size construct.

Maybe more words about how we know this is wrong in some ways.
Comment 4 zalan 2020-03-05 14:57:19 PST 
Created attachment 392630 [details]
Patch
Comment 5 zalan 2020-03-05 14:58:48 PST 
Created attachment 392631 [details]
Patch
Comment 6 WebKit Commit Bot 2020-03-05 15:44:03 PST 
Comment on attachment 392631 [details]
Patch

Clearing flags on attachment: 392631

Committed r257952: <https://trac.webkit.org/changeset/257952>
Comment 7 WebKit Commit Bot 2020-03-05 15:44:04 PST 
All reviewed patches have been landed.  Closing bug.