Bug 208658 - Fix for several failures of LayoutTests in isolated tree mode.
Summary: Fix for several failures of LayoutTests in isolated tree mode.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andres Gonzalez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-05 12:26 PST by Andres Gonzalez
Modified: 2020-03-05 15:09 PST (History)
11 users (show)

See Also:

Attachments
Patch (7.78 KB, patch)
2020-03-05 12:32 PST, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Patch (8.16 KB, patch)
2020-03-05 13:23 PST, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andres Gonzalez 2020-03-05 12:26:53 PST 
Fix for several failures of LayoutTests in isolated tree mode.
Comment 1 Andres Gonzalez 2020-03-05 12:32:44 PST 
Created attachment 392606 [details]
Patch
Comment 2 Andres Gonzalez 2020-03-05 13:23:43 PST 
Created attachment 392615 [details]
Patch
Comment 3 WebKit Commit Bot 2020-03-05 14:29:50 PST 
The commit-queue encountered the following flaky tests while processing attachment 392615 [details]:

editing/spelling/spellcheck-input-search-crash.html bug 207995 (authors: arv@chromium.org, g.czajkowski@samsung.com, mark.lam@apple.com, and morrita@google.com)
The commit-queue is continuing to process your patch.
Comment 4 WebKit Commit Bot 2020-03-05 14:30:08 PST 
The commit-queue encountered the following flaky tests while processing attachment 392615 [details]:

editing/spelling/spellcheck-paste-continuous-disabled.html bug 208016 (authors: g.czajkowski@samsung.com and mark.lam@apple.com)
The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2020-03-05 14:50:36 PST 
Comment on attachment 392615 [details]
Patch

Clearing flags on attachment: 392615

Committed r257948: <https://trac.webkit.org/changeset/257948>
Comment 6 WebKit Commit Bot 2020-03-05 14:50:38 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2020-03-05 14:51:27 PST 
<rdar://problem/60101614>
Comment 8 Simon Fraser (smfr) 2020-03-05 15:02:15 PST 
Comment on attachment 392615 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392615&action=review

> Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:830
> +    ScrollView* scrollView() const override;

Is this called off the main thread?
Comment 9 Andres Gonzalez 2020-03-05 15:09:48 PST 
(In reply to Simon Fraser (smfr) from comment #8)
> Comment on attachment 392615 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=392615&action=review
> 
> > Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:830
> > +    ScrollView* scrollView() const override;
> 
> Is this called off the main thread?

no, it is called in a lambda dispatched to the main thread with:

return Accessibility::retrieveAutoreleasedValueFromMainThread<id>(...)

The implementation in the IsolatedObject will assert if it is not on the main thread.