Undefined behavior in JavaScriptCore due to missing return statements. <rdar://problem/60090482>
Created attachment 392599 [details] Patch v1
Comment on attachment 392599 [details] Patch v1 r=me
I think this is intentional. We would like to make B3/Air's generated code for the super frequently used functions as much as possible. And we intentionally avoid using RELEASE_ASSERT_NOT_REACHED(), and instead, using IGNORE_RETURN_TYPE_WARNINGS_BEGIN to suppress this type of warnings. So I don't think we should use RELEASE_ASSERT_NOT_REACHED().
Comment on attachment 392599 [details] Patch v1 Removing r+ given Yusuke's comment.
(In reply to Yusuke Suzuki from comment #3) > I think this is intentional. We would like to make B3/Air's generated code > for the super frequently used functions as much as possible. And we > intentionally avoid using RELEASE_ASSERT_NOT_REACHED(), and instead, using > IGNORE_RETURN_TYPE_WARNINGS_BEGIN to suppress this type of warnings. So I > don't think we should use RELEASE_ASSERT_NOT_REACHED(). Okay, moving NTBF. Looks like IGNORE_RETURN_TYPE_WARNINGS_BEGIN macros are already in these files. This issue was found by a different tool.