WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
208637
Add logging support for capture sources in GPUProcess
https://bugs.webkit.org/show_bug.cgi?id=208637
Summary
Add logging support for capture sources in GPUProcess
youenn fablet
Reported
2020-03-05 05:46:36 PST
Add logging support for capture sources in GPUProcess
Attachments
Patch
(8.50 KB, patch)
2020-03-05 05:49 PST
,
youenn fablet
no flags
Details
Formatted Diff
Diff
Patch
(8.51 KB, patch)
2020-03-05 05:51 PST
,
youenn fablet
no flags
Details
Formatted Diff
Diff
Patch
(8.55 KB, patch)
2020-03-05 05:58 PST
,
youenn fablet
no flags
Details
Formatted Diff
Diff
Patch
(8.96 KB, patch)
2020-03-05 08:24 PST
,
youenn fablet
no flags
Details
Formatted Diff
Diff
Show Obsolete
(3)
View All
Add attachment
proposed patch, testcase, etc.
youenn fablet
Comment 1
2020-03-05 05:49:05 PST
Created
attachment 392559
[details]
Patch
youenn fablet
Comment 2
2020-03-05 05:51:54 PST
Created
attachment 392560
[details]
Patch
youenn fablet
Comment 3
2020-03-05 05:58:56 PST
Created
attachment 392561
[details]
Patch
Eric Carlson
Comment 4
2020-03-05 06:19:58 PST
Comment on
attachment 392561
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=392561&action=review
> Source/WebCore/platform/mediastream/RealtimeVideoSource.cpp:160 > + source->setLogger(logger(), source.ptr());
We're not supposed use pointers for log identifiers. You could use childLogIdentifier(...) like we do for AudioContext and MediaSourcePrivateAVFObjC.
> Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:209 > + source->setLogger(m_connectionProxy->logger(), source.ptr());
Ditto.
youenn fablet
Comment 5
2020-03-05 08:24:27 PST
Created
attachment 392573
[details]
Patch
WebKit Commit Bot
Comment 6
2020-03-05 09:13:06 PST
Comment on
attachment 392573
[details]
Patch Clearing flags on attachment: 392573 Committed
r257919
: <
https://trac.webkit.org/changeset/257919
>
WebKit Commit Bot
Comment 7
2020-03-05 09:13:08 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8
2020-03-05 09:14:16 PST
<
rdar://problem/60086438
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug