Bug 208637 - Add logging support for capture sources in GPUProcess
Summary: Add logging support for capture sources in GPUProcess
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-05 05:46 PST by youenn fablet
Modified: 2020-03-05 09:14 PST (History)
11 users (show)

See Also:

Attachments
Patch (8.50 KB, patch)
2020-03-05 05:49 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (8.51 KB, patch)
2020-03-05 05:51 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (8.55 KB, patch)
2020-03-05 05:58 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (8.96 KB, patch)
2020-03-05 08:24 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2020-03-05 05:46:36 PST 
Add logging support for capture sources in GPUProcess
Comment 1 youenn fablet 2020-03-05 05:49:05 PST 
Created attachment 392559 [details]
Patch
Comment 2 youenn fablet 2020-03-05 05:51:54 PST 
Created attachment 392560 [details]
Patch
Comment 3 youenn fablet 2020-03-05 05:58:56 PST 
Created attachment 392561 [details]
Patch
Comment 4 Eric Carlson 2020-03-05 06:19:58 PST 
Comment on attachment 392561 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392561&action=review

> Source/WebCore/platform/mediastream/RealtimeVideoSource.cpp:160
> +    source->setLogger(logger(), source.ptr());

We're not supposed use pointers for log identifiers. You could use childLogIdentifier(...) like we do for AudioContext and MediaSourcePrivateAVFObjC.

> Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:209
> +        source->setLogger(m_connectionProxy->logger(), source.ptr());

Ditto.
Comment 5 youenn fablet 2020-03-05 08:24:27 PST 
Created attachment 392573 [details]
Patch
Comment 6 WebKit Commit Bot 2020-03-05 09:13:06 PST 
Comment on attachment 392573 [details]
Patch

Clearing flags on attachment: 392573

Committed r257919: <https://trac.webkit.org/changeset/257919>
Comment 7 WebKit Commit Bot 2020-03-05 09:13:08 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2020-03-05 09:14:16 PST 
<rdar://problem/60086438>