Bug 208629 - AX: Provide a way to run tests in isolated tree mode
Summary: AX: Provide a way to run tests in isolated tree mode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: chris fleizach
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-05 00:55 PST by chris fleizach
Modified: 2020-03-08 08:50 PDT (History)
14 users (show)

See Also:

Attachments
patch (18.11 KB, patch)
2020-03-05 01:04 PST, chris fleizach 		no flags Details | Formatted Diff | Diff
patch (18.14 KB, patch)
2020-03-05 01:09 PST, chris fleizach 		no flags Details | Formatted Diff | Diff
patch (18.19 KB, patch)
2020-03-05 07:37 PST, chris fleizach 		no flags Details | Formatted Diff | Diff
patch (18.19 KB, patch)
2020-03-05 07:56 PST, chris fleizach 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description chris fleizach 2020-03-05 00:55:26 PST 
Accessibility isolated tree mode is a bit difficult to test, because it relies on specific requests entering the system on a secondary thread.

To simulate this environment, we need a new argument to pass into test runner that can set it up correctly.
Comment 1 Radar WebKit Bug Importer 2020-03-05 00:55:36 PST 
<rdar://problem/60075583>
Comment 2 chris fleizach 2020-03-05 01:04:05 PST 
Created attachment 392544 [details]
patch
Comment 3 chris fleizach 2020-03-05 01:09:16 PST 
Created attachment 392545 [details]
patch
Comment 4 Stephan Szabo 2020-03-05 07:34:31 PST 
Comment on attachment 392545 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392545&action=review

> Tools/WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:35
> +#include <pal/spi/mac/HIServicesSPI.h>

This appears to be breaking on GTK and WinCairo, should it be behind 
#if ENABLE(ACCESSIBILITY_ISOLATED_TREE) ?
Comment 5 chris fleizach 2020-03-05 07:37:37 PST 
Created attachment 392566 [details]
patch
Comment 6 chris fleizach 2020-03-05 07:56:01 PST 
Created attachment 392569 [details]
patch
Comment 7 Ryosuke Niwa 2020-03-06 19:16:20 PST 
Comment on attachment 392569 [details]
patch

Seems okay to me.
Comment 8 WebKit Commit Bot 2020-03-07 10:35:02 PST 
Comment on attachment 392569 [details]
patch

Clearing flags on attachment: 392569

Committed r258075: <https://trac.webkit.org/changeset/258075>
Comment 9 WebKit Commit Bot 2020-03-07 10:35:04 PST 
All reviewed patches have been landed.  Closing bug.