Bug 208623 - Make m_slowRepaintObjects a WeakHashSet
Summary: Make m_slowRepaintObjects a WeakHashSet
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-04 21:42 PST by Simon Fraser (smfr)
Modified: 2020-03-04 23:18 PST (History)
6 users (show)

See Also:

Attachments
Patch (6.30 KB, patch)
2020-03-04 21:43 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2020-03-04 21:42:12 PST 
Make m_slowRepaintObjects a WeakHashSet
Comment 1 Simon Fraser (smfr) 2020-03-04 21:43:11 PST 
Created attachment 392534 [details]
Patch
Comment 2 WebKit Commit Bot 2020-03-04 22:38:28 PST 
Comment on attachment 392534 [details]
Patch

Clearing flags on attachment: 392534

Committed r257902: <https://trac.webkit.org/changeset/257902>
Comment 3 WebKit Commit Bot 2020-03-04 22:38:30 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2020-03-04 22:39:14 PST 
<rdar://problem/60072474>
Comment 5 Antti Koivisto 2020-03-04 23:18:27 PST 
Comment on attachment 392534 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392534&action=review

> Source/WebCore/page/FrameView.h:826
>      std::unique_ptr<ListHashSet<RenderEmbeddedObject*>> m_embeddedObjectsToUpdate;

We need WeakListHashSet too.