RESOLVED FIXED 208620
Track "scrolling scope" on RenderLayers 
https://bugs.webkit.org/show_bug.cgi?id=208620
Summary Track "scrolling scope" on RenderLayers
Simon Fraser (smfr)
Reported 2020-03-04 18:25:49 PST
Track "scrolling scope" on RenderLayers
Attachments
Patch (9.79 KB, patch)
2020-03-04 18:31 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (9.01 KB, patch)
2020-03-10 18:23 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2020-03-04 18:31:23 PST
Created attachment 392526 [details] Patch
zalan
Comment 2 2020-03-04 19:39:32 PST
Comment on attachment 392526 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392526&action=review > Source/WebCore/ChangeLog:12 > + Each layer has two scopes; a "box" scope that applies to the background/borders, and wouldn't decoration scope be a better name if it is only about background and borders?
Simon Fraser (smfr)
Comment 3 2020-03-04 19:59:22 PST
(In reply to zalan from comment #2) > Comment on attachment 392526 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=392526&action=review > > > Source/WebCore/ChangeLog:12 > > + Each layer has two scopes; a "box" scope that applies to the background/borders, and > > wouldn't decoration scope be a better name if it is only about background > and borders? I thought of that, but it's more about the scrolling element's box, which doesn't move.
WebKit Commit Bot
Comment 4 2020-03-05 09:17:28 PST
The commit-queue encountered the following flaky tests while processing attachment 392526 [details]: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 5 2020-03-05 09:18:05 PST
Comment on attachment 392526 [details] Patch Clearing flags on attachment: 392526 Committed r257920: <https://trac.webkit.org/changeset/257920>
WebKit Commit Bot
Comment 6 2020-03-05 09:18:06 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2020-03-05 09:19:16 PST
<rdar://problem/60086595>
Simon Fraser (smfr)
Comment 8 2020-03-10 14:29:52 PDT
Partially reverted in https://trac.webkit.org/changeset/258229/webkit because it broke gmail.
Simon Fraser (smfr)
Comment 9 2020-03-10 18:23:28 PDT
Created attachment 393197 [details] Patch
WebKit Commit Bot
Comment 10 2020-03-10 20:26:09 PDT
Comment on attachment 393197 [details] Patch Clearing flags on attachment: 393197 Committed r258249: <https://trac.webkit.org/changeset/258249>
WebKit Commit Bot
Comment 11 2020-03-10 20:26:10 PDT
All reviewed patches have been landed. Closing bug.
Truitt Savell
Comment 12 2020-03-13 08:15:16 PDT
New test added in this commit is flaky, tracking in https://bugs.webkit.org/show_bug.cgi?id=209052
Note You need to log in before you can comment on or make changes to this bug.