Bug 208619 – WebsiteDataStore methods often create process pools and launch network processes unnecessarily

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chris Dumez]

WebsiteDataStore methods often create process pools and launch network processes unnecessarily.

[Chris Dumez]

Created attachment 392523 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 392523 [details]
Patch

Clearing flags on attachment: 392523

Committed r257904: <https://trac.webkit.org/changeset/257904>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/60073109>

[Darin Adler]

Comment on attachment 392523 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392523&action=review

> Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:1256
> +    for (auto& processPool : ensureProcessPools())

This one is still ensureProcessPools. I’m presuming that’s intentional, but I don’t see any explanation of that.

[Chris Dumez]

Comment on attachment 392523 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392523&action=review

>> Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:1256
>> +    for (auto& processPool : ensureProcessPools())
> 
> This one is still ensureProcessPools. I’m presuming that’s intentional, but I don’t see any explanation of that.

This actually goes and adds the prevalent resource in the ITP database on disk. Therefore, creating a process pool and a network process to go add this entry is not a no-op.

In practice, this gets called by JS via testRunner so we always have a process pool / network process when this gets called so this is not contributing to Bug 208541 (which is what I am trying to address).