Bug 208611 - Some media tests crash when run in the GPU process
Summary: Some media tests crash when run in the GPU process
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-04 15:42 PST by Eric Carlson
Modified: 2020-03-05 10:27 PST (History)
7 users (show)

See Also:

Attachments
Patch (6.92 KB, patch)
2020-03-04 15:58 PST, Eric Carlson 		no flags Details | Formatted Diff | Diff
Patch (6.95 KB, patch)
2020-03-04 16:56 PST, Eric Carlson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2020-03-04 15:42:40 PST 
Some media tests crash when run in the GPU process
Comment 1 Radar WebKit Bug Importer 2020-03-04 15:42:52 PST 
<rdar://problem/60060320>
Comment 2 Eric Carlson 2020-03-04 15:58:09 PST 
Created attachment 392499 [details]
Patch
Comment 3 Eric Carlson 2020-03-04 16:56:18 PST 
Created attachment 392512 [details]
Patch
Comment 4 Jer Noble 2020-03-05 09:27:18 PST 
Comment on attachment 392512 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392512&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:2291
> +    bool satisfied = [m_videoOutputDelegate semaphore].waitFor(1_s);

nit: This could also be written as `m_videoOutputDelegate.get().semaphore.waitFor(1_s);` but I don't know what the current policy for this kind of thing is.
Comment 5 WebKit Commit Bot 2020-03-05 10:27:08 PST 
Comment on attachment 392512 [details]
Patch

Clearing flags on attachment: 392512

Committed r257926: <https://trac.webkit.org/changeset/257926>
Comment 6 WebKit Commit Bot 2020-03-05 10:27:09 PST 
All reviewed patches have been landed.  Closing bug.