Bug 208606 – [VNE layout] Move visually non-empty content reporting to RenderTreeBuilder

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[alan baradlay]

from the renderer c'tors

[Radar WebKit Bug Importer]

<rdar://problem/60056951>

[alan baradlay]

Created attachment 392487 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 392487 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392487&action=review

> Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:925
> +        if (style.visibility() == Visibility::Visible && !style.fontCascade().isLoadingCustomFonts()) {

The isLoadingCustomFonts() seems wrong. It might be loading custom fonts but rendering with the fallback font, right? There's CSS to control this.

Also I guess we don't care about style.visibility() == Hidden on an ancestor?

[alan baradlay]

(In reply to Simon Fraser (smfr) from comment #3)
> Comment on attachment 392487 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=392487&action=review
> 
> > Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:925
> > +        if (style.visibility() == Visibility::Visible && !style.fontCascade().isLoadingCustomFonts()) {
> 
> The isLoadingCustomFonts() seems wrong. It might be loading custom fonts but
> rendering with the fallback font, right? There's CSS to control this.
> 
> Also I guess we don't care about style.visibility() == Hidden on an ancestor?
Yeah. This is very basic.

[alan baradlay]

Created attachment 392503 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 392503 [details]
Patch

Clearing flags on attachment: 392503

Committed r257899: <https://trac.webkit.org/changeset/257899>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.