Bug 208594 - Adopt new and improved CFNetwork SPI for cookie change notifications
Summary: Adopt new and improved CFNetwork SPI for cookie change notifications
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-04 13:19 PST by Chris Dumez
Modified: 2020-03-04 15:28 PST (History)
5 users (show)

See Also:

Attachments
Patch (18.51 KB, patch)
2020-03-04 13:27 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (18.67 KB, patch)
2020-03-04 14:26 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-03-04 13:19:25 PST 
Adopt new and improved CFNetwork SPI for cookie change notifications.
Comment 1 Radar WebKit Bug Importer 2020-03-04 13:19:42 PST 
<rdar://problem/60053313>
Comment 2 Chris Dumez 2020-03-04 13:27:32 PST 
Created attachment 392469 [details]
Patch
Comment 3 Chris Dumez 2020-03-04 14:26:02 PST 
Created attachment 392484 [details]
Patch
Comment 4 Chris Dumez 2020-03-04 14:28:15 PST 
Comment on attachment 392484 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392484&action=review

> Source/WebCore/platform/network/cocoa/NetworkStorageSessionCocoa.mm:595
> +            if (cookies.isEmpty())

The only change in this latest iteration was early returning here if the list of cookies is empty after filtering out the httpOnly ones. No need to do unnecessary IPC in this case.
Comment 5 WebKit Commit Bot 2020-03-04 15:28:18 PST 
Comment on attachment 392484 [details]
Patch

Clearing flags on attachment: 392484

Committed r257888: <https://trac.webkit.org/changeset/257888>
Comment 6 WebKit Commit Bot 2020-03-04 15:28:20 PST 
All reviewed patches have been landed.  Closing bug.