Bug 208570 – frame/iframe scrolling attribute does to recognize value "noscroll" or "off"

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Frédéric Wang (:fredw)]

From https://html.spec.whatwg.org/multipage/rendering.html#the-page:

> If a Document's browsing context is a child browsing context, the container of that browsing context is a frame or iframe element, that element has a scrolling attribute, and that attribute's value is an ASCII case-insensitive match for the string "off", "noscroll", or "no", then the user agent is expected to prevent any scrollbars from being shown for the viewport of the Document's browsing context, regardless of the 'overflow' property that applies to that viewport.

Source/WebCore/html/HTMLFrameElementBase.cpp only handles "no":

ScrollbarMode HTMLFrameElementBase::scrollingMode() const
{
    return equalLettersIgnoringASCIICase(attributeWithoutSynchronization(scrollingAttr), "no")
        ? ScrollbarAlwaysOff : ScrollbarAuto;
}

Gecko recognizes the three values and Chromium added support for them after fixing https://bugs.chromium.org/p/chromium/issues/detail?id=1057454

WPT test was added in https://chromium-review.googlesource.com/c/chromium/src/+/2085396

[Frédéric Wang (:fredw)]

This should be trivial fix. I can take care of this.

[Frédéric Wang (:fredw)]

Created attachment 392550 [details]
WIP Patch

WPT tests haven't arrived yet into the WPT repos, so we need to wait before taking this...

[Mason Freed]

WPT tests are hung up here: https://github.com/web-platform-tests/wpt/pull/22072

[Simon Fraser (smfr)]

Are "off", "noscroll", or "no" synonymous?

[Frédéric Wang (:fredw)]

(In reply to Simon Fraser (smfr) from comment #4)
> Are "off", "noscroll", or "no" synonymous?

In HTML5, yes (see comment 0).

Maybe this was different in HTML4.

[Frédéric Wang (:fredw)]

Created attachment 393825 [details]
Patch

[Rob Buis]

Comment on attachment 393825 [details]
Patch

Approved also since Maciej indicated it as a reasonable change.

[WebKit Commit Bot]

Comment on attachment 393825 [details]
Patch

Clearing flags on attachment: 393825

Committed r258651: <https://trac.webkit.org/changeset/258651>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/60592188>