Bug 208567 - WebChromeClient::createImageBuffer should not create a connection to GPU Process if page does not want remote rendering
Summary: WebChromeClient::createImageBuffer should not create a connection to GPU Proc...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-04 01:33 PST by youenn fablet
Modified: 2020-03-04 08:42 PST (History)
8 users (show)

See Also:

Attachments
Patch (5.98 KB, patch)
2020-03-04 01:49 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2020-03-04 01:33:44 PST 
WebChromeClient::createImageBuffer should not create a connection to GPU Process if page does not want remote rendering
Comment 1 youenn fablet 2020-03-04 01:47:26 PST 
<rdar://problem/60020229>
Comment 2 youenn fablet 2020-03-04 01:49:19 PST 
Created attachment 392394 [details]
Patch
Comment 3 WebKit Commit Bot 2020-03-04 08:32:05 PST 
Comment on attachment 392394 [details]
Patch

Clearing flags on attachment: 392394

Committed r257845: <https://trac.webkit.org/changeset/257845>
Comment 4 WebKit Commit Bot 2020-03-04 08:32:06 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Said Abou-Hallawa 2020-03-04 08:41:09 PST 
Comment on attachment 392394 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392394&action=review

> Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp:-910
> -    RenderingMode mode;
> -    if (m_page.shouldUseRemoteRenderingFor(purpose))
> -        mode = shouldAccelerate == ShouldAccelerate::Yes ? RenderingMode::RemoteAccelerated : RenderingMode::RemoteUnaccelerated;
> -    else if (shouldUseDisplayList == ShouldUseDisplayList::Yes)
> -        mode = shouldAccelerate == ShouldAccelerate::Yes ? RenderingMode::DisplayListAccelerated : RenderingMode::DisplayListUnaccelerated;
> -    else
> -        mode = shouldAccelerate == ShouldAccelerate::Yes ? RenderingMode::Accelerated : RenderingMode::Unaccelerated;
> -    return ensureRemoteRenderingBackend().createImageBuffer(size, mode, resolutionScale, colorSpace);

With this change, the argument 'shouldUseDisplayList' became unused. How does not the compiler catch this?
Comment 6 youenn fablet 2020-03-04 08:42:51 PST 
> With this change, the argument 'shouldUseDisplayList' became unused. How
> does not the compiler catch this?

WebCore has that constraint, not WebKit.
It would be nice to be consistent.