RESOLVED FIXED 208565
Should use -bounds instead of -frame in RequestTextInputContext.mm tests 
https://bugs.webkit.org/show_bug.cgi?id=208565
Summary Should use -bounds instead of -frame in RequestTextInputContext.mm tests
Daniel Bates
Reported 2020-03-04 00:29:20 PST
In the tests in RequestTextInputContext.mm they call -synchronouslyRequestTextInputContextsInRect passing in the web view's frame to find all the editable elements in the visible content area of the page. This works out for these tests because the web view's frame is always located a the origin of the window (0, ). If the web view wasn't located at the origin of the window then these tests may fail. For correctness, these tests should pass the web view's bounds.
Attachments
For the bots (10.54 KB, patch)
2020-03-04 00:40 PST, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Patch (8.84 KB, patch)
2020-03-04 00:41 PST, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2020-03-04 00:40:36 PST
Created attachment 392388 [details] For the bots
Daniel Bates
Comment 2 2020-03-04 00:41:17 PST
Created attachment 392389 [details] Patch
Daniel Bates
Comment 3 2020-03-04 10:07:11 PST
Thanks for the review
Daniel Bates
Comment 4 2020-03-04 10:07:50 PST
Comment on attachment 392389 [details] Patch Clearing flags on attachment: 392389 Committed r257854: <https://trac.webkit.org/changeset/257854>
Daniel Bates
Comment 5 2020-03-04 10:07:52 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2020-03-04 10:08:16 PST
<rdar://problem/60044473>
Note You need to log in before you can comment on or make changes to this bug.