Bug 208565 - Should use -bounds instead of -frame in RequestTextInputContext.mm tests
Summary: Should use -bounds instead of -frame in RequestTextInputContext.mm tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: iPhone / iPad iOS 13
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on: 208564
Blocks:
  Show dependency tree / graph
 
Reported: 2020-03-04 00:29 PST by Daniel Bates
Modified: 2020-03-04 10:08 PST (History)
2 users (show)

See Also:

Attachments
For the bots (10.54 KB, patch)
2020-03-04 00:40 PST, Daniel Bates 		no flags Details | Formatted Diff | Diff
Patch (8.84 KB, patch)
2020-03-04 00:41 PST, Daniel Bates 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2020-03-04 00:29:20 PST 
In the tests in RequestTextInputContext.mm they call -synchronouslyRequestTextInputContextsInRect passing in the web view's frame to find all the editable elements in the visible content area of the page. This works out for these tests because the web view's frame is always located a the origin of the window (0, ). If the web view wasn't located at the origin of the window then these tests may fail. For correctness, these tests should pass the web view's bounds.
Comment 1 Daniel Bates 2020-03-04 00:40:36 PST 
Created attachment 392388 [details]
For the bots
Comment 2 Daniel Bates 2020-03-04 00:41:17 PST 
Created attachment 392389 [details]
Patch
Comment 3 Daniel Bates 2020-03-04 10:07:11 PST 
Thanks for the review
Comment 4 Daniel Bates 2020-03-04 10:07:50 PST 
Comment on attachment 392389 [details]
Patch

Clearing flags on attachment: 392389

Committed r257854: <https://trac.webkit.org/changeset/257854>
Comment 5 Daniel Bates 2020-03-04 10:07:52 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2020-03-04 10:08:16 PST 
<rdar://problem/60044473>