Bug 208558 - [LFC][IFC] Display::Run::TextContent::expand(unsigned) is called with the value of -1.
Summary: [LFC][IFC] Display::Run::TextContent::expand(unsigned) is called with the val...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-03 21:34 PST by zalan
Modified: 2020-03-04 07:19 PST (History)
6 users (show)

See Also:

Attachments
Patch (2.30 KB, patch)
2020-03-04 06:31 PST, zalan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2020-03-03 21:34:31 PST 
shrink it!
Comment 1 Radar WebKit Bug Importer 2020-03-03 21:35:02 PST 
<rdar://problem/60026658>
Comment 2 zalan 2020-03-04 06:31:00 PST 
Created attachment 392408 [details]
Patch
Comment 3 Antti Koivisto 2020-03-04 06:33:13 PST 
Comment on attachment 392408 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392408&action=review

> Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp:-836
> -    m_textContent->expand(-1);

wut

> Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp:837
> +    constexpr size_t trailingTrimmableContentLength = 1;
> +    m_textContent->shrink(trailingTrimmableContentLength);

I have concerns.
Comment 4 zalan 2020-03-04 06:34:12 PST 
(In reply to Antti Koivisto from comment #3)
> Comment on attachment 392408 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=392408&action=review
> 
> > Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp:-836
> > -    m_textContent->expand(-1);
> 
> wut
> 
> > Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp:837
> > +    constexpr size_t trailingTrimmableContentLength = 1;
> > +    m_textContent->shrink(trailingTrimmableContentLength);
> 
> I have concerns.
Me too!
Comment 5 WebKit Commit Bot 2020-03-04 07:19:20 PST 
Comment on attachment 392408 [details]
Patch

Clearing flags on attachment: 392408

Committed r257841: <https://trac.webkit.org/changeset/257841>
Comment 6 WebKit Commit Bot 2020-03-04 07:19:21 PST 
All reviewed patches have been landed.  Closing bug.