Bug 208556 - REGRESSION(iOS): editing/selection/ios/set-selection-by-tapping-after-changing-focused-element-bounds.html is always timing out
Summary: REGRESSION(iOS): editing/selection/ios/set-selection-by-tapping-after-changin...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-03 20:24 PST by Ryosuke Niwa
Modified: 2020-03-03 20:58 PST (History)
3 users (show)

See Also:

Attachments
Fixes the test (1.89 KB, patch)
2020-03-03 20:28 PST, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2020-03-03 20:24:21 PST 
Fix the test.

<rdar://problem/60015298>
Comment 1 Ryosuke Niwa 2020-03-03 20:28:13 PST 
Created attachment 392365 [details]
Fixes the test
Comment 2 Wenson Hsieh 2020-03-03 20:40:13 PST 
Comment on attachment 392365 [details]
Fixes the test

View in context: https://bugs.webkit.org/attachment.cgi?id=392365&action=review

> LayoutTests/ChangeLog:10
> +        as a single dobule tap.

(Nit - dobule => double)
Comment 3 Ryosuke Niwa 2020-03-03 20:42:31 PST 
(In reply to Wenson Hsieh from comment #2)
> Comment on attachment 392365 [details]
> Fixes the test
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=392365&action=review
> 
> > LayoutTests/ChangeLog:10
> > +        as a single dobule tap.
> 
> (Nit - dobule => double)

Oops, fixed.
Comment 4 Ryosuke Niwa 2020-03-03 20:48:49 PST 
Comment on attachment 392365 [details]
Fixes the test

Clearing flags on attachment: 392365

Committed r257821: <https://trac.webkit.org/changeset/257821>
Comment 5 Ryosuke Niwa 2020-03-03 20:48:51 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2020-03-03 20:49:13 PST 
<rdar://problem/60025775>
Comment 7 Ryosuke Niwa 2020-03-03 20:51:09 PST 
Oh weird. The typo is not fixed in the change log :(
Comment 8 Ryosuke Niwa 2020-03-03 20:58:02 PST 
Fixed the typo in https://trac.webkit.org/changeset/257822/webkit.