WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
208554
Add SPI _WKResourceLoadInfo.loadedFromCache
https://bugs.webkit.org/show_bug.cgi?id=208554
Summary
Add SPI _WKResourceLoadInfo.loadedFromCache
Alex Christensen
Reported
2020-03-03 19:22:14 PST
Add SPI _WKResourceLoadInfo.loadedFromCache
Attachments
Patch
(8.39 KB, patch)
2020-03-03 19:40 PST
,
Alex Christensen
wenson_hsieh
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Alex Christensen
Comment 1
2020-03-03 19:40:01 PST
Created
attachment 392363
[details]
Patch
Wenson Hsieh
Comment 2
2020-03-03 21:58:42 PST
Comment on
attachment 392363
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=392363&action=review
> Source/WebKit/ChangeLog:6 > + Reviewed by NOBODY (OOPS!).
Nit - it’s admittedly pretty self-explanatory, but it would be nice to have a sentence or two explaining what this new SPI does.
> Tools/TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:328 > + EXPECT_EQ(archiveData.length, 589ull);
Ideally we'd have a test that checks the value of -loadedFromCache, but maybe it can be done as a followup.
Alex Christensen
Comment 3
2020-03-03 22:11:56 PST
http://trac.webkit.org/r257834
Radar WebKit Bug Importer
Comment 4
2020-03-03 22:12:16 PST
<
rdar://problem/60027433
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug