Bug 208554 - Add SPI _WKResourceLoadInfo.loadedFromCache
Summary: Add SPI _WKResourceLoadInfo.loadedFromCache
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-03 19:22 PST by Alex Christensen
Modified: 2020-03-03 22:12 PST (History)
2 users (show)

See Also:

Attachments
Patch (8.39 KB, patch)
2020-03-03 19:40 PST, Alex Christensen 		wenson_hsieh: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2020-03-03 19:22:14 PST 
Add SPI _WKResourceLoadInfo.loadedFromCache
Comment 1 Alex Christensen 2020-03-03 19:40:01 PST 
Created attachment 392363 [details]
Patch
Comment 2 Wenson Hsieh 2020-03-03 21:58:42 PST 
Comment on attachment 392363 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392363&action=review

> Source/WebKit/ChangeLog:6
> +        Reviewed by NOBODY (OOPS!).

Nit - it’s admittedly pretty self-explanatory, but it would be nice to have a sentence or two explaining what this new SPI does.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:328
> +    EXPECT_EQ(archiveData.length, 589ull);

Ideally we'd have a test that checks the value of -loadedFromCache, but maybe it can be done as a followup.
Comment 3 Alex Christensen 2020-03-03 22:11:56 PST 
http://trac.webkit.org/r257834
Comment 4 Radar WebKit Bug Importer 2020-03-03 22:12:16 PST 
<rdar://problem/60027433>