Bug 208549 – Web Inspector: AXI: can't leave Styles and Computed panels by pressing Tab

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Nikita Vasilyev]

Once the focus is inside of the Styles or Computed panel, it's trapped there. You can't escape the panel by pressing Tab. Focus cycles inside the panel.


Steps:
1. Open Styles panel.
2. Focus on the filter field at the bottom of the sidebar.
3. Press Tab.

Expected:
Focus moves forward to "Classes" toggle button.

Actual:
Focus "cycles" back to the top of the sidebar - to the "Active" checkbox.


Steps:
1. Focus on the first checkbox - "Active".
2. Press Shift-Tab.

Expected:
Focus moves to "Styles" sidebar tab.

Actual:
Focus moves to the filter field at the bottom of the sidebar.

[Radar WebKit Bug Importer]

<rdar://problem/60020149>

[Nikita Vasilyev]

Created attachment 392354 [details]
Patch

[Devin Rousso]

Comment on attachment 392354 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392354&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/GeneralStyleDetailsSidebarPanel.js:419
> +        if (event.shiftKey && this._panel.focusLastSection) {

Why not mimic `_handleForcedPseudoClassCheckboxKeydown` and have `if (event.key !== "Tab" || !event.shiftKey)` instead?  That way, `if (this._panel.focusLastSection)` lines up quite nicely with the `this._panel.focusLastSection();` on the next line :)

[Nikita Vasilyev]

Created attachment 392645 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 392645 [details]
Patch

Clearing flags on attachment: 392645

Committed r257959: <https://trac.webkit.org/changeset/257959>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.