Bug 208548 - Add signposts for top-level script execution
Summary: Add signposts for top-level script execution
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ben Nham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-03 17:01 PST by Ben Nham
Modified: 2020-03-05 16:02 PST (History)
8 users (show)

See Also:


Attachments
Patch (3.30 KB, patch)
2020-03-03 17:08 PST, Ben Nham
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Nham 2020-03-03 17:01:47 PST
Add signposts for top-level script execution
Comment 1 Ben Nham 2020-03-03 17:08:54 PST
Created attachment 392350 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2020-03-03 17:09:24 PST
<rdar://problem/60020308>
Comment 3 Ben Nham 2020-03-05 15:04:13 PST
Alex was a bit concerned about the URL being logged in the signpost, but that is pretty important to making the signpost actually useful. It is sensitive data and WTFSignpost takes care of that by not logging the signpost unless a profiling environment variable is set and the code is running on an AppleInternal system.
Comment 4 WebKit Commit Bot 2020-03-05 16:02:54 PST
Comment on attachment 392350 [details]
Patch

Clearing flags on attachment: 392350

Committed r257955: <https://trac.webkit.org/changeset/257955>
Comment 5 WebKit Commit Bot 2020-03-05 16:02:55 PST
All reviewed patches have been landed.  Closing bug.