RESOLVED FIXED Bug 208539
[ews] Add build step to create local git commit for commit-queue 
https://bugs.webkit.org/show_bug.cgi?id=208539
Summary [ews] Add build step to create local git commit for commit-queue
Aakash Jain
Reported 2020-03-03 14:44:06 PST
Add build step to create local git commit for commit-queue (in new EWS).
Attachments
Patch (6.07 KB, patch)
2020-03-03 14:46 PST, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Patch (9.01 KB, patch)
2020-03-04 08:02 PST, Aakash Jain 		jbedard: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2020-03-03 14:46:58 PST
Created attachment 392337 [details] Patch
Aakash Jain
Comment 2 2020-03-03 14:47:59 PST
Sample run: https://ews-build.webkit-uat.org/#/builders/26/builds/1059
Jonathan Bedard
Comment 3 2020-03-03 15:17:31 PST
Comment on attachment 392337 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392337&action=review > Tools/BuildSlaveSupport/ews-build/steps.py:2474 > + commit_message_filename = '/tmp/{}.txt'.format(self.getProperty('patch_id')) Any reason we can't store the commit_message in a purporter and then use 'git commit --all --file -' and pip the commit message over stdin? Seems cleaner than sending it into a file.
Aakash Jain
Comment 4 2020-03-04 08:02:30 PST
Created attachment 392415 [details] Patch
Aakash Jain
Comment 5 2020-03-04 08:03:28 PST
(In reply to Jonathan Bedard from comment #3) > Any reason we can't store the commit_message in a purporter and then use 'git commit --all --file -' and pipe the commit message over stdin? Done in updated patch.
Jonathan Bedard
Comment 6 2020-03-04 09:10:00 PST
Comment on attachment 392415 [details] Patch Much cleaner all in the same step!
Aakash Jain
Comment 7 2020-03-04 09:40:24 PST
Committed r257848: <https://trac.webkit.org/changeset/257848>
Radar WebKit Bug Importer
Comment 8 2020-03-04 09:41:17 PST
<rdar://problem/60043246>
Note You need to log in before you can comment on or make changes to this bug.