Bug 208537 - Refactor FixedVMPoolExecutableAllocator to not have member functions which are really just helper functions
Summary: Refactor FixedVMPoolExecutableAllocator to not have member functions which ar...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
: 208116 (view as bug list)
Depends on:
Blocks: 208490
  Show dependency tree / graph
 
Reported: 2020-03-03 14:19 PST by Saam Barati
Modified: 2020-03-03 16:19 PST (History)
14 users (show)

See Also:

Attachments
patch (26.45 KB, patch)
2020-03-03 14:41 PST, Saam Barati 		mark.lam: review+
Details | Formatted Diff | Diff
patch for landing (26.45 KB, patch)
2020-03-03 15:09 PST, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2020-03-03 14:19:19 PST 
This will make it easier when implementing the 1GB executable space on arm64
Comment 1 Saam Barati 2020-03-03 14:19:53 PST 
*** Bug 208116 has been marked as a duplicate of this bug. ***
Comment 2 Saam Barati 2020-03-03 14:41:00 PST 
Created attachment 392336 [details]
patch
Comment 3 Saam Barati 2020-03-03 14:57:59 PST 
Comment on attachment 392336 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392336&action=review

> Source/JavaScriptCore/jit/ExecutableAllocator.cpp:405
>  private:

will fix the double "private:" in a row
Comment 4 Mark Lam 2020-03-03 15:02:47 PST 
Comment on attachment 392336 [details]
patch

r=me
Comment 5 Saam Barati 2020-03-03 15:09:17 PST 
Created attachment 392339 [details]
patch for landing
Comment 6 WebKit Commit Bot 2020-03-03 16:18:35 PST 
Comment on attachment 392339 [details]
patch for landing

Clearing flags on attachment: 392339

Committed r257812: <https://trac.webkit.org/changeset/257812>
Comment 7 WebKit Commit Bot 2020-03-03 16:18:37 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2020-03-03 16:19:17 PST 
<rdar://problem/60018354>