RESOLVED FIXED 208534
[Win] API header file has USE macro 
https://bugs.webkit.org/show_bug.cgi?id=208534
Summary [Win] API header file has USE macro
Per Arne Vollan
Reported 2020-03-03 13:22:26 PST
USE macros should not be used in API header files.
Attachments
Patch (1.19 KB, patch)
2020-03-03 13:26 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2020-03-03 13:26:53 PST
Created attachment 392319 [details] Patch
Brent Fulgham
Comment 2 2020-03-03 13:29:01 PST
Comment on attachment 392319 [details] Patch Whoops!
Brent Fulgham
Comment 3 2020-03-03 13:29:58 PST
Comment on attachment 392319 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392319&action=review > Source/WebKitLegacy/win/WebKitCOMAPI.h:-45 > -#if USE(CF) I think all configurations of WinCairo still requires CFLite, so I guess we always expect CFBundle to be define.
Per Arne Vollan
Comment 4 2020-03-03 13:30:46 PST
(In reply to Brent Fulgham from comment #3) > Comment on attachment 392319 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=392319&action=review > > > Source/WebKitLegacy/win/WebKitCOMAPI.h:-45 > > -#if USE(CF) > > I think all configurations of WinCairo still requires CFLite, so I guess we > always expect CFBundle to be define. Thanks for reviewing!
Per Arne Vollan
Comment 5 2020-03-03 13:39:53 PST
rdar://problem/60009752
WebKit Commit Bot
Comment 6 2020-03-03 14:20:03 PST
Comment on attachment 392319 [details] Patch Clearing flags on attachment: 392319 Committed r257802: <https://trac.webkit.org/changeset/257802>
WebKit Commit Bot
Comment 7 2020-03-03 14:20:04 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.