Bug 208534 - [Win] API header file has USE macro
Summary: [Win] API header file has USE macro
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-03 13:22 PST by Per Arne Vollan
Modified: 2020-03-03 14:20 PST (History)
3 users (show)

See Also:


Attachments
Patch (1.19 KB, patch)
2020-03-03 13:26 PST, Per Arne Vollan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2020-03-03 13:22:26 PST
USE macros should not be used in API header files.
Comment 1 Per Arne Vollan 2020-03-03 13:26:53 PST
Created attachment 392319 [details]
Patch
Comment 2 Brent Fulgham 2020-03-03 13:29:01 PST
Comment on attachment 392319 [details]
Patch

Whoops!
Comment 3 Brent Fulgham 2020-03-03 13:29:58 PST
Comment on attachment 392319 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392319&action=review

> Source/WebKitLegacy/win/WebKitCOMAPI.h:-45
> -#if USE(CF)

I think all configurations of WinCairo still requires CFLite, so I guess we always expect CFBundle to be define.
Comment 4 Per Arne Vollan 2020-03-03 13:30:46 PST
(In reply to Brent Fulgham from comment #3)
> Comment on attachment 392319 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=392319&action=review
> 
> > Source/WebKitLegacy/win/WebKitCOMAPI.h:-45
> > -#if USE(CF)
> 
> I think all configurations of WinCairo still requires CFLite, so I guess we
> always expect CFBundle to be define.

Thanks for reviewing!
Comment 5 Per Arne Vollan 2020-03-03 13:39:53 PST
rdar://problem/60009752
Comment 6 WebKit Commit Bot 2020-03-03 14:20:03 PST
Comment on attachment 392319 [details]
Patch

Clearing flags on attachment: 392319

Committed r257802: <https://trac.webkit.org/changeset/257802>
Comment 7 WebKit Commit Bot 2020-03-03 14:20:04 PST
All reviewed patches have been landed.  Closing bug.