Bug 208526 - [iOS] Add entitlement for message filtering
Summary: [iOS] Add entitlement for message filtering
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-03 11:12 PST by Per Arne Vollan
Modified: 2020-03-03 13:12 PST (History)
3 users (show)

See Also:

Attachments
Patch (1.44 KB, patch)
2020-03-03 11:14 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2020-03-03 11:12:32 PST 
On iOS, an entitlement is needed to enable message filtering.
Comment 1 Per Arne Vollan 2020-03-03 11:12:56 PST 
rdar://problem/58885485
Comment 2 Per Arne Vollan 2020-03-03 11:14:35 PST 
Created attachment 392302 [details]
Patch
Comment 3 Brent Fulgham 2020-03-03 11:59:02 PST 
Comment on attachment 392302 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392302&action=review

r=me

> Source/WebKit/Scripts/process-entitlements.sh:139
> +    plistbuddy Add :com.apple.private.security.message-filter bool YES

Is this needed for MacCatalyst or macOS?
Comment 4 Per Arne Vollan 2020-03-03 12:30:33 PST 
(In reply to Brent Fulgham from comment #3)
> Comment on attachment 392302 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=392302&action=review
> 
> r=me
> 
> > Source/WebKit/Scripts/process-entitlements.sh:139
> > +    plistbuddy Add :com.apple.private.security.message-filter bool YES
> 
> Is this needed for MacCatalyst or macOS?

As far as I know, I don't think it is needed at this point.

Thanks for reviewing!
Comment 5 WebKit Commit Bot 2020-03-03 13:12:57 PST 
Comment on attachment 392302 [details]
Patch

Clearing flags on attachment: 392302

Committed r257797: <https://trac.webkit.org/changeset/257797>
Comment 6 WebKit Commit Bot 2020-03-03 13:12:58 PST 
All reviewed patches have been landed.  Closing bug.