Bug 208520 – REGRESSION (r257739): two fast/events/autoscroll test have started to fail

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Jacob Uphoff]

The following tests started to fail after commit r257739:
fast/events/autoscroll-in-iframe.html
fast/events/autoscroll-in-iframe-body.html

History:

https://results.webkit.org/?suite=layout-tests&suite=layout-tests&test=fast/events/autoscroll-in-iframe.html&test=fast/events/autoscroll-in-iframe-body.html&platform=ios

[Radar WebKit Bug Importer]

<rdar://problem/60000214>

[Alexey Proskuryakov]

@@ -1,3 +1,4 @@
 
+FAILED: Clicking in the iframe scrolled the page (window.scrollTop is 0)
 PASSED: selecting in the iframe did not scroll the page.

[Andres Gonzalez]

Created attachment 392361 [details]
Patch

[chris fleizach]

Comment on attachment 392361 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392361&action=review

> Tools/WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:-49
> -#if PLATFORM(COCOA)

I think we should tie this to the isolated tree feature flag

[chris fleizach]

Comment on attachment 392361 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392361&action=review

>> Tools/WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:-49
>> -#if PLATFORM(COCOA)
> 
> I think we should tie this to the isolated tree feature flag

Actually I see there are some larger issues using that in Tools that I’m addressing In another patch. So this should be ok for now

[WebKit Commit Bot]

Comment on attachment 392361 [details]
Patch

Clearing flags on attachment: 392361

Committed r257838: <https://trac.webkit.org/changeset/257838>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.