Bug 208507 - Test media/video-controls-toggling.html is failing for GTK since r257299
Summary: Test media/video-controls-toggling.html is failing for GTK since r257299
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-03 03:28 PST by Carlos Garcia Campos
Modified: 2020-03-03 05:14 PST (History)
8 users (show)

See Also:


Attachments
Patch (2.76 KB, patch)
2020-03-03 03:33 PST, Carlos Garcia Campos
calvaris: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2020-03-03 03:28:31 PST
This has started to fail for GTK since we switched to use adwaita media controls, but I think this was passing by coincidence. The test itself is wrong and that's probably the reason why it fails in the other platforms too. The test expects that the changes that happen after removing the controls attribute from video element are sync, but they aren't because a mutation observer is used by media controls script. Then it assumes that panel display property is set to none after controls attribute is removed, but we are actually removing the media controls tree from the DOM in that case so the panel is null at that point. This worked in GTK before because all those checks that were supposed to happen after removing the controls were done before the handleControlsChange() was called.
Comment 1 Carlos Garcia Campos 2020-03-03 03:33:04 PST
Created attachment 392259 [details]
Patch
Comment 2 Carlos Garcia Campos 2020-03-03 05:13:19 PST
Committed r257771: <https://trac.webkit.org/changeset/257771>
Comment 3 Radar WebKit Bug Importer 2020-03-03 05:14:28 PST
<rdar://problem/59992415>